[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505117#comment-15505117
]
Guozhang Wang commented on KAFKA-4153:
--
Thanks [~elevy], I have added you to the contributor list so
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505113#comment-15505113
]
ASF GitHub Bot commented on KAFKA-4153:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491553#comment-15491553
]
Elias Levy commented on KAFKA-4153:
---
I've updated the PR to reverse the before & after semantics as
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491329#comment-15491329
]
Guozhang Wang commented on KAFKA-4153:
--
According to the stated Java doc string, {{JoinWindows}}
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485826#comment-15485826
]
Elias Levy commented on KAFKA-4153:
---
Why would the other value be undefined? Default it to zero.
>
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485759#comment-15485759
]
Matthias J. Sax commented on KAFKA-4153:
IMHO {{JoinWindows.before(100).after(50)}} would not be a
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485700#comment-15485700
]
Elias Levy commented on KAFKA-4153:
---
You could do that, but it would be non-obvious to someone reading
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485638#comment-15485638
]
Matthias J. Sax commented on KAFKA-4153:
Well, you can just call
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485561#comment-15485561
]
Elias Levy commented on KAFKA-4153:
---
As a side note, the API for {{JoinWindows}} has become mangled
[
https://issues.apache.org/jira/browse/KAFKA-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485524#comment-15485524
]
ASF GitHub Bot commented on KAFKA-4153:
---
GitHub user eliaslevy opened a pull request:
10 matches
Mail list logo