[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961463#comment-15961463 ] Jiangjie Qin commented on KAFKA-4401: - Sure, I just linked KAFKA-5041 to this ticket so we can see the discussions here. > Change the KafkaServerTestHarness and IntegrationTestHarness from trait to > abstract class. > -- > > Key: KAFKA-4401 > URL: https://issues.apache.org/jira/browse/KAFKA-4401 > Project: Kafka > Issue Type: Task > Components: unit tests >Affects Versions: 0.10.1.0 >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > > The IntegartionTestHarness and KafkaServerTestHarness are useful not only in > Kafka unit test, but also useful for the unit tests in other products that > depend on Kafka. > Currently there are two issues making those two test harness classes hard to > use by other Java users. > 1. The two classes are Scala traits. This makes it difficult for people to > write Java unit test code. > 2. Some of the interfaces are Scala only. > It will be good to expose those two classes for more general usage and make > them Java friendly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961033#comment-15961033 ] Ismael Juma commented on KAFKA-4401: Note that we changed both classes to be abstract classes as well as ZooKeeperTestHarness so that we could place the IntegrationTest annotation (i.e. @Category(Array(classOf[IntegrationTest]))`) in the base class. With traits, this would not work. Additionally, I filed KAFKA-5041 for creating a supported library for writing tests involving a Kafka cluster. Given that, I suggest closing this one. What do you think [~becket_qin]? > Change the KafkaServerTestHarness and IntegrationTestHarness from trait to > abstract class. > -- > > Key: KAFKA-4401 > URL: https://issues.apache.org/jira/browse/KAFKA-4401 > Project: Kafka > Issue Type: Task > Components: unit tests >Affects Versions: 0.10.1.0 >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > > The IntegartionTestHarness and KafkaServerTestHarness are useful not only in > Kafka unit test, but also useful for the unit tests in other products that > depend on Kafka. > Currently there are two issues making those two test harness classes hard to > use by other Java users. > 1. The two classes are Scala traits. This makes it difficult for people to > write Java unit test code. > 2. Some of the interfaces are Scala only. > It will be good to expose those two classes for more general usage and make > them Java friendly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836729#comment-15836729 ] Ewen Cheslack-Postava commented on KAFKA-4401: -- [~becket_qin] I would actually like to eventually propose in a KIP that we make some of these public since so many people are already relying on them/copying them in Java/etc :) So when we go through adding a Java version it'd be great to keep an eye on the public interface, exposing only what we need and ensuring it's sufficiently general. > Change the KafkaServerTestHarness and IntegrationTestHarness from trait to > abstract class. > -- > > Key: KAFKA-4401 > URL: https://issues.apache.org/jira/browse/KAFKA-4401 > Project: Kafka > Issue Type: Task > Components: unit tests >Affects Versions: 0.10.1.0 >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > > The IntegartionTestHarness and KafkaServerTestHarness are useful not only in > Kafka unit test, but also useful for the unit tests in other products that > depend on Kafka. > Currently there are two issues making those two test harness classes hard to > use by other Java users. > 1. The two classes are Scala traits. This makes it difficult for people to > write Java unit test code. > 2. Some of the interfaces are Scala only. > It will be good to expose those two classes for more general usage and make > them Java friendly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[
https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825006#comment-15825006
]
Jiangjie Qin commented on KAFKA-4401:
-
[~ewencp] I think it is a good suggestion. Technically speaking we haven't
claimed the test harness classes are "public interface". So we can think of we
are adding a new public test harness interfaces that are {{Unstable}} and
subject to changes.
> Change the KafkaServerTestHarness and IntegrationTestHarness from trait to
> abstract class.
> --
>
> Key: KAFKA-4401
> URL: https://issues.apache.org/jira/browse/KAFKA-4401
> Project: Kafka
> Issue Type: Task
> Components: unit tests
>Affects Versions: 0.10.1.0
>Reporter: Jiangjie Qin
>Assignee: Jiangjie Qin
> Fix For: 0.10.2.0
>
>
> The IntegartionTestHarness and KafkaServerTestHarness are useful not only in
> Kafka unit test, but also useful for the unit tests in other products that
> depend on Kafka.
> Currently there are two issues making those two test harness classes hard to
> use by other Java users.
> 1. The two classes are Scala traits. This makes it difficult for people to
> write Java unit test code.
> 2. Some of the interfaces are Scala only.
> It will be good to expose those two classes for more general usage and make
> them Java friendly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[
https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823518#comment-15823518
]
Ewen Cheslack-Postava commented on KAFKA-4401:
--
Could we make incremental progress on this by marking some of the classes we
already have as {{Unstable}}? Maybe by giving some access without promises re:
compatibility would improve the situation?
> Change the KafkaServerTestHarness and IntegrationTestHarness from trait to
> abstract class.
> --
>
> Key: KAFKA-4401
> URL: https://issues.apache.org/jira/browse/KAFKA-4401
> Project: Kafka
> Issue Type: Task
> Components: unit tests
>Affects Versions: 0.10.1.0
>Reporter: Jiangjie Qin
>Assignee: Jiangjie Qin
> Fix For: 0.10.2.0
>
>
> The IntegartionTestHarness and KafkaServerTestHarness are useful not only in
> Kafka unit test, but also useful for the unit tests in other products that
> depend on Kafka.
> Currently there are two issues making those two test harness classes hard to
> use by other Java users.
> 1. The two classes are Scala traits. This makes it difficult for people to
> write Java unit test code.
> 2. Some of the interfaces are Scala only.
> It will be good to expose those two classes for more general usage and make
> them Java friendly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665238#comment-15665238 ] Ismael Juma commented on KAFKA-4401: Kafka Streams also has helpers for tests that are nicer to use from Java (EmbeddedKafkaCluster, KafkaEmbedded). If we want to encourage people to use our test harness classes, we should think about compatibility guarantees. And that implies exposing a simple and supportable interface instead (IntegrationTestHarness and KafkaServerTestHarness expose too much IMO). Having said that, I think it's a good idea, if done right. > Change the KafkaServerTestHarness and IntegrationTestHarness from trait to > abstract class. > -- > > Key: KAFKA-4401 > URL: https://issues.apache.org/jira/browse/KAFKA-4401 > Project: Kafka > Issue Type: Task > Components: unit tests >Affects Versions: 0.10.1.0 >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > Fix For: 0.10.1.1 > > > The IntegartionTestHarness and KafkaServerTestHarness are useful not only in > Kafka unit test, but also useful for the unit tests in other products that > depend on Kafka. > Currently there are two issues making those two test harness classes hard to > use by other Java users. > 1. The two classes are Scala traits. This makes it difficult for people to > write Java unit test code. > 2. Some of the interfaces are Scala only. > It will be good to expose those two classes for more general usage and make > them Java friendly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665054#comment-15665054 ] Jiangjie Qin commented on KAFKA-4401: - [~ewencp] Interestingly, we have done the same thing as well for a few of our Java projects :) I completely agree that it is important to reduce the time to run unit test and we should avoid doing so in our own tests whenever possible. That said, I found it is handy for many external projects to have the capability to run some simple functional test with in memory Kafka setup. Otherwise they may have to write more costly and complicated system test. So it seems useful for Kafka to provide the test harness tool to facilitate the external project testing. But the external projects should use their own judgement to decide when to use the test harness. For example, just like you mentioned, there are some tests that can be run relatively quickly with the test harness in the Confluent schema registry while others may more suitable for the system test. > Change the KafkaServerTestHarness and IntegrationTestHarness from trait to > abstract class. > -- > > Key: KAFKA-4401 > URL: https://issues.apache.org/jira/browse/KAFKA-4401 > Project: Kafka > Issue Type: Task > Components: unit tests >Affects Versions: 0.10.1.0 >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > Fix For: 0.10.1.1 > > > The IntegartionTestHarness and KafkaServerTestHarness are useful not only in > Kafka unit test, but also useful for the unit tests in other products that > depend on Kafka. > Currently there are two issues making those two test harness classes hard to > use by other Java users. > 1. The two classes are Scala traits. This makes it difficult for people to > write Java unit test code. > 2. Some of the interfaces are Scala only. > It will be good to expose those two classes for more general usage and make > them Java friendly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4401) Change the KafkaServerTestHarness and IntegrationTestHarness from trait to abstract class.
[ https://issues.apache.org/jira/browse/KAFKA-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662147#comment-15662147 ] Ewen Cheslack-Postava commented on KAFKA-4401: -- [~becket_qin] We've already done much of this work for some of our Java-based projects, e.g. see https://github.com/confluentinc/schema-registry/blob/master/core/src/test/java/io/confluent/kafka/schemaregistry/ClusterTestHarness.java and with variants for security, e.g. https://github.com/confluentinc/schema-registry/blob/master/core/src/test/java/io/confluent/kafka/schemaregistry/SSLClusterTestHarness.java. These have actually caused a bit of pain because they rely on internals so can break unexpectedly due to changes in Kafka. Given that, it would be handy if they were just part of Kafka itself. We could probably lift most of these implementations directly (they include schema registry startup as well, but that should be trivial to strip out.) That said, we've actually moved away from including integration tests like this in most of our projects in favor of putting tests like these into system tests. They remain in our schema registry and REST proxy mainly for historical reasons, i.e. the cost of refactoring them hasn't become worth it in these cases since the tests can still run relatively quickly (compared to Kafka's tests which now have so many integration tests that they dominate the 15-20 minute test runtime on a developer laptop). I'm a bit torn as to whether this would be a good addition; on the one hand people are doing this so standardizing it and avoiding 83 different implementations seems good, on the other hand I think it leads to people dumping too many tests that are actually system tests into tests that they call integration tests and run via unit tests... > Change the KafkaServerTestHarness and IntegrationTestHarness from trait to > abstract class. > -- > > Key: KAFKA-4401 > URL: https://issues.apache.org/jira/browse/KAFKA-4401 > Project: Kafka > Issue Type: Task > Components: unit tests >Affects Versions: 0.10.1.0 >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > Fix For: 0.10.1.1 > > > The IntegartionTestHarness and KafkaServerTestHarness are useful not only in > Kafka unit test, but also useful for the unit tests in other products that > depend on Kafka. > Currently there are two issues making those two test harness classes hard to > use by other Java users. > 1. The two classes are Scala traits. This makes it difficult for people to > write Java unit test code. > 2. Some of the interfaces are Scala only. > It will be good to expose those two classes for more general usage and make > them Java friendly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
