[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-12-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743437#comment-15743437 ] Ismael Juma commented on KAFKA-4405: Thanks for the PR [~enothereska]. Can you please update the JIRA

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742591#comment-15742591 ] ASF GitHub Bot commented on KAFKA-4405: --- Github user asfgit closed the pull request at:

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-12-01 Thread Eno Thereska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711481#comment-15711481 ] Eno Thereska commented on KAFKA-4405: - [~guozhang] Ignore previous comment, I was testing by mistake

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711475#comment-15711475 ] ASF GitHub Bot commented on KAFKA-4405: --- GitHub user enothereska reopened a pull request:

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-12-01 Thread Eno Thereska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711461#comment-15711461 ] Eno Thereska commented on KAFKA-4405: - [~guozhang]I tested with the new trunk containing KAFKA-4469

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711450#comment-15711450 ] ASF GitHub Bot commented on KAFKA-4405: --- Github user enothereska closed the pull request at:

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-30 Thread Eno Thereska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708052#comment-15708052 ] Eno Thereska commented on KAFKA-4405: - I opened a PR since the performance difference is still

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708050#comment-15708050 ] ASF GitHub Bot commented on KAFKA-4405: --- GitHub user enothereska opened a pull request:

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-29 Thread ysysberserk (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707215#comment-15707215 ] ysysberserk commented on KAFKA-4405: Oh, I am sorry that I only read the code and did not notice that

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-29 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706166#comment-15706166 ] Guozhang Wang commented on KAFKA-4405: -- Thanks [~enothereska]. > Kafka consumer improperly send

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-29 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705691#comment-15705691 ] Ismael Juma commented on KAFKA-4405: [~ysysberserk], are you really seeing the behaviour you have

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-29 Thread Eno Thereska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705655#comment-15705655 ] Eno Thereska commented on KAFKA-4405: - [~ijuma] yes. > Kafka consumer improperly send prefetch

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-29 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705594#comment-15705594 ] Ismael Juma commented on KAFKA-4405: [~enothereska], do you mean the following? {code}

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-29 Thread Eno Thereska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705475#comment-15705475 ] Eno Thereska commented on KAFKA-4405: - [~guozhang], [~hachikuji] Indeed I can verify that I saw a 50%

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-27 Thread ysysberserk (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701241#comment-15701241 ] ysysberserk commented on KAFKA-4405: It seems to me that it is not only a performance problem but will

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-27 Thread ysysberserk (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701118#comment-15701118 ] ysysberserk commented on KAFKA-4405: It sounds better, I will check it. But comparing the total

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701064#comment-15701064 ] Guozhang Wang commented on KAFKA-4405: -- [~enothereska] Maybe this can result in performance

[jira] [Commented] (KAFKA-4405) Kafka consumer improperly send prefetch request

2016-11-27 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700704#comment-15700704 ] Jason Gustafson commented on KAFKA-4405: I think a better approach is KAFKA-4007. The idea is to