[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566563#comment-13566563
]
Jun Rao commented on KAFKA-683:
---
Yes, the main changes were made by me in kafka-203. If we
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566599#comment-13566599
]
Jay Kreps commented on KAFKA-683:
-
The design was that the network layer is fully generic
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566234#comment-13566234
]
Jay Kreps commented on KAFKA-683:
-
Yeah, I am on the fence about the metrics stuff, maybe
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551550#comment-13551550
]
Jun Rao commented on KAFKA-683:
---
The changes in core/src/test/resources/log4j.properties are
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549792#comment-13549792
]
Jun Rao commented on KAFKA-683:
---
Patch v2 doesn't seem to apply on 0.8. Could you rebase?
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549967#comment-13549967
]
Neha Narkhede commented on KAFKA-683:
-
That is a good suggestion. However, that still
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544506#comment-13544506
]
Jun Rao commented on KAFKA-683:
---
Thanks for the patch. Some comments:
1.
