[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584827#comment-13584827 ] Jun Rao commented on KAFKA-736: --- Thanks for patch v4. Looks good. A few minor comments. Once

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-22 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584903#comment-13584903 ] Sriram Subramanian commented on KAFKA-736: -- +1 Add an option to

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577800#comment-13577800 ] Jun Rao commented on KAFKA-736: --- Because of the problem identified in KAFKA-706, only the v3

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571485#comment-13571485 ] Neha Narkhede commented on KAFKA-736: - Producer performance does not measure latency

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569828#comment-13569828 ] Jun Rao commented on KAFKA-736: --- Thanks for the results. The case with 20 producer threads is

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569840#comment-13569840 ] Neha Narkhede commented on KAFKA-736: - In all the tests above, the number of partitions

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-02 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569670#comment-13569670 ] Neha Narkhede commented on KAFKA-736: - Benchmarked the draft and v2 patches for

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-01 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569224#comment-13569224 ] Jay Kreps commented on KAFKA-736: - Reviewing the draft patch in case we end up going that

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-01 Thread ben fleis (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569294#comment-13569294 ] ben fleis commented on KAFKA-736: - Went back and tested the 'draft' patch, and this failed

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-01-31 Thread ben fleis (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568192#comment-13568192 ] ben fleis commented on KAFKA-736: - I tried the v2 patch linked above this morning against

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-01-30 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566883#comment-13566883 ] Jay Kreps commented on KAFKA-736: - 1. It would be good to remove getShutdownReceive() too.

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-01-29 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566215#comment-13566215 ] Jay Kreps commented on KAFKA-736: - This is basically good, but the comments and naming are