Re: 回复: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server
Hi, I've updated the PR based on the discussion and the comments on the PR. If there are no more issues, I'll start a vote in a few days. Thanks, Daniel wang120445...@sina.com ezt írta (időpont: 2020. júl. 1., Sze, 3:26): > maybe it just likes RBAC’s show tables； > > > > wang120445...@sina.com > > 发件人： Hu Xi > 发送时间： 2020-06-30 23:04 > 收件人： dev@kafka.apache.org > 主题： 回复: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support > for multiple topics, minimize the number of requests to server > That's a great KIP for GetOffsetShell tool. I have a question about the > multiple-topic lookup situation. > > In a secured environment, what does the tool output if it has DESCRIBE > privileges for some topics but hasn't for others? > > > 发件人: Dániel Urbán > 发送时间: 2020年6月30日 22:15 > 收件人: dev@kafka.apache.org > 主题: Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support > for multiple topics, minimize the number of requests to server > > Hi Manikumar, > Thanks, went ahead and assigned a new ID, it is KIP-635 now: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override > Daniel > > Manikumar ezt írta (időpont: 2020. jún. 30., > K, > 16:03): > > > Hi, > > > > Yes, we can assign new id to this KIP. > > > > Thanks. > > > > On Tue, Jun 30, 2020 at 6:59 PM Dániel Urbán > > wrote: > > > > > Hi, > > > > > > To help with the discussion, I also have a PR for this KIP now. > > reflecting > > > the current state of the KIP: > https://github.com/apache/kafka/pull/8957. > > > I would like to ask a committer to start the test job on it. > > > > > > One thing I realised though is that there is a KIP id collision, there > is > > > another KIP with the same id: > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=85474993 > > > What is the protocol in this case? Should I acquire a new id for the > > > GetOffsetShell KIP, and update it? > > > > > > Thanks in advance, > > > Daniel > > > > > > Dániel Urbán ezt írta (időpont: 2020. > jún. > > > 30., K, 9:23): > > > > > > > Hi Manikumar, > > > > > > > > Thanks for the comments. > > > > 1. Will change this - thought that "command-config" is used for admin > > > > clients. > > > > 2. It's not necessary, just felt like a nice quality-of-life feature > - > > > will > > > > remove it. > > > > > > > > Thanks, > > > > Daniel > > > > > > > > On Tue, Jun 30, 2020 at 4:16 AM Manikumar > > > > > wrote: > > > > > > > > > Hi Daniel, > > > > > > > > > > Thanks for working on this KIP. Proposed changes looks good to me, > > > > > > > > > > minor comments: > > > > > 1. We use "command-config" option name in most of the cmdline tools > > to > > > > pass > > > > > config > > > > > properties file. We can use the same name here. > > > > > > > > > > 2. Not sure, if we need a separate option to pass an consumer > > property. > > > > > fewer options are better. > > > > > > > > > > Thanks, > > > > > Manikumar > > > > > > > > > > On Wed, Jun 24, 2020 at 8:53 PM Dániel Urbán < > urb.dani...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > I see that this KIP turned somewhat inactive - I'd like to pick > it > > up > > > > and > > > > > > work on it if it is okay. > > > > > > Part of the work is done, as switching to the Consumer API is > > already > > > > in > > > > > > trunk, but some functionality is still missing. > > > > > > > > > > > > I've seen the current PR and the discussion so far, only have a > few > > > > > things > > > > > > to add: > > > > > > - I like the idea of the topic-partition argument, it would be > > useful > > > > to > > > > > > filter down to specific partitions. > > > > > > - Instead of a topic list arg, a pattern would be more powerful, > > and > > > > also > > > > > > fit better with the other tools (e.g. how the kafka-topics tool > > > works). > > > > > > > > > > > > Regards, > > > > > > Daniel > > > > > > > > > > > > > > > > > > > > >
Re: 回复: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server
maybe it just likes RBAC’s show tables； wang120445...@sina.com 发件人： Hu Xi 发送时间： 2020-06-30 23:04 收件人： dev@kafka.apache.org 主题： 回复: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server That's a great KIP for GetOffsetShell tool. I have a question about the multiple-topic lookup situation. In a secured environment, what does the tool output if it has DESCRIBE privileges for some topics but hasn't for others? 发件人: Dániel Urbán 发送时间: 2020年6月30日 22:15 收件人: dev@kafka.apache.org 主题: Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server Hi Manikumar, Thanks, went ahead and assigned a new ID, it is KIP-635 now: https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override Daniel Manikumar ezt írta (időpont: 2020. jún. 30., K, 16:03): > Hi, > > Yes, we can assign new id to this KIP. > > Thanks. > > On Tue, Jun 30, 2020 at 6:59 PM Dániel Urbán > wrote: > > > Hi, > > > > To help with the discussion, I also have a PR for this KIP now. > reflecting > > the current state of the KIP: https://github.com/apache/kafka/pull/8957. > > I would like to ask a committer to start the test job on it. > > > > One thing I realised though is that there is a KIP id collision, there is > > another KIP with the same id: > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=85474993 > > What is the protocol in this case? Should I acquire a new id for the > > GetOffsetShell KIP, and update it? > > > > Thanks in advance, > > Daniel > > > > Dániel Urbán ezt írta (időpont: 2020. jún. > > 30., K, 9:23): > > > > > Hi Manikumar, > > > > > > Thanks for the comments. > > > 1. Will change this - thought that "command-config" is used for admin > > > clients. > > > 2. It's not necessary, just felt like a nice quality-of-life feature - > > will > > > remove it. > > > > > > Thanks, > > > Daniel > > > > > > On Tue, Jun 30, 2020 at 4:16 AM Manikumar > > > wrote: > > > > > > > Hi Daniel, > > > > > > > > Thanks for working on this KIP. Proposed changes looks good to me, > > > > > > > > minor comments: > > > > 1. We use "command-config" option name in most of the cmdline tools > to > > > pass > > > > config > > > > properties file. We can use the same name here. > > > > > > > > 2. Not sure, if we need a separate option to pass an consumer > property. > > > > fewer options are better. > > > > > > > > Thanks, > > > > Manikumar > > > > > > > > On Wed, Jun 24, 2020 at 8:53 PM Dániel Urbán > > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > I see that this KIP turned somewhat inactive - I'd like to pick it > up > > > and > > > > > work on it if it is okay. > > > > > Part of the work is done, as switching to the Consumer API is > already > > > in > > > > > trunk, but some functionality is still missing. > > > > > > > > > > I've seen the current PR and the discussion so far, only have a few > > > > things > > > > > to add: > > > > > - I like the idea of the topic-partition argument, it would be > useful > > > to > > > > > filter down to specific partitions. > > > > > - Instead of a topic list arg, a pattern would be more powerful, > and > > > also > > > > > fit better with the other tools (e.g. how the kafka-topics tool > > works). > > > > > > > > > > Regards, > > > > > Daniel > > > > > > > > > > > > > > >
回复: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server
That's a great KIP for GetOffsetShell tool. I have a question about the multiple-topic lookup situation. In a secured environment, what does the tool output if it has DESCRIBE privileges for some topics but hasn't for others? 发件人: Dániel Urbán 发送时间: 2020年6月30日 22:15 收件人: dev@kafka.apache.org 主题: Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server Hi Manikumar, Thanks, went ahead and assigned a new ID, it is KIP-635 now: https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override Daniel Manikumar ezt írta (időpont: 2020. jún. 30., K, 16:03): > Hi, > > Yes, we can assign new id to this KIP. > > Thanks. > > On Tue, Jun 30, 2020 at 6:59 PM Dániel Urbán > wrote: > > > Hi, > > > > To help with the discussion, I also have a PR for this KIP now. > reflecting > > the current state of the KIP: https://github.com/apache/kafka/pull/8957. > > I would like to ask a committer to start the test job on it. > > > > One thing I realised though is that there is a KIP id collision, there is > > another KIP with the same id: > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=85474993 > > What is the protocol in this case? Should I acquire a new id for the > > GetOffsetShell KIP, and update it? > > > > Thanks in advance, > > Daniel > > > > Dániel Urbán ezt írta (időpont: 2020. jún. > > 30., K, 9:23): > > > > > Hi Manikumar, > > > > > > Thanks for the comments. > > > 1. Will change this - thought that "command-config" is used for admin > > > clients. > > > 2. It's not necessary, just felt like a nice quality-of-life feature - > > will > > > remove it. > > > > > > Thanks, > > > Daniel > > > > > > On Tue, Jun 30, 2020 at 4:16 AM Manikumar > > > wrote: > > > > > > > Hi Daniel, > > > > > > > > Thanks for working on this KIP. Proposed changes looks good to me, > > > > > > > > minor comments: > > > > 1. We use "command-config" option name in most of the cmdline tools > to > > > pass > > > > config > > > > properties file. We can use the same name here. > > > > > > > > 2. Not sure, if we need a separate option to pass an consumer > property. > > > > fewer options are better. > > > > > > > > Thanks, > > > > Manikumar > > > > > > > > On Wed, Jun 24, 2020 at 8:53 PM Dániel Urbán > > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > I see that this KIP turned somewhat inactive - I'd like to pick it > up > > > and > > > > > work on it if it is okay. > > > > > Part of the work is done, as switching to the Consumer API is > already > > > in > > > > > trunk, but some functionality is still missing. > > > > > > > > > > I've seen the current PR and the discussion so far, only have a few > > > > things > > > > > to add: > > > > > - I like the idea of the topic-partition argument, it would be > useful > > > to > > > > > filter down to specific partitions. > > > > > - Instead of a topic list arg, a pattern would be more powerful, > and > > > also > > > > > fit better with the other tools (e.g. how the kafka-topics tool > > works). > > > > > > > > > > Regards, > > > > > Daniel > > > > > > > > > > > > > > >
