RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hello! Below you will find the latest state of the Mockito migration. 81% or 39/48 of streams-related tests have been migrated. The last 5 pull requests which are in need of reviews are: * https://github.com/apache/kafka/pull/12449 * https://github.com/apache/kafka/pull/12524 *

RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hello! This email summarises the current state of Kafka's Mockito migration. The JIRA tickets used to track the progress are https://issues.apache.org/jira/browse/KAFKA-14132 and https://issues.apache.org/jira/browse/KAFKA-14133

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hello, I have not been able to make a lot of progress on the Mockito migration myself, but Yash and Divij opened and merged a PR each. The following PRs have made it into trunk: https://github.com/apache/kafka/pull/12615 https://github.com/apache/kafka/pull/12677

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Thanks Christo for the updates. As we are adding new unit tests we are also keen on using the new Mockito packages and so far I'd like to say it's much easier to use :) would chime in to help on reviewing some of the PRs as well. Guozhang On Tue, Sep 6, 2022 at 11:02 PM Christo Lolov wrote: >

RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hello! This is the (roughly) bi-weekly update on the Mockito migration. Firstly, the following PRs have been merged since the last email so thank you to the writers (Yash and Divij) and reviewers (Dalibor, Mickael, Yash, Bruno and Chris): https://github.com/apache/kafka/pull/12459

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hello! Apologies for the delay in my reply. I have started working on migrating the  TaskManagerTest to Mockito, but have not raised a pull request yet. It is on the list in https://issues.apache.org/jira/browse/KAFKA-14133 and I will add you as a reviewer the moment I publish it. Best,Christo

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Thanks everyone for the great effort! Just one quick question regarding the Streams tests: I looked over https://github.com/apache/kafka/pull/12492/files, https://github.com/apache/kafka/pull/12505/files and https://github.com/apache/kafka/pull/12465/files, but I did not find the one covering

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hello! Following Divij's example I wanted to give an update on the progress being made. With a combined effort from Yash Mayya, Matthew de Detrich and myself we are 3/4 through providing pull requests for moving the remaining EasyMock tests to Mockito

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

I will assign myself to 14132 and 14133, thanks for the detailed notes on gotchas for the migration. Regards -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m:

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hi everyone To provide you with quick updates on the progress. Open PRs (pending review): 1. Streams - https://github.com/apache/kafka/pull/12449 2. Streams - https://github.com/apache/kafka/pull/12465 3. Streams - https://github.com/apache/kafka/pull/12459 4. Connect -

Last sprint to finish line: Replace EasyMock/Powermock with Mockito

Hi folks We have been trying to replace EasyMock/Powermock with Mockito for quite a while. This adds complications for migrating to JDK 17 & Junit5. Significant contributions have been made by various folks towards this goal and the finish line