Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26714 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26717 --- Ship it! Ship It! - Neha Narkhede On Oct. 5, 2013, 6:02 p.m.,

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Neha Narkhede
On Oct. 6, 2013, 8 p.m., Swapnil Ghike wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 61-65 https://reviews.apache.org/r/14496/diff/2/?file=361683#file361683line61 Instead of asking the user to store the output of a dryrun into a JSON file, should

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Guozhang Wang
On Oct. 6, 2013, 8 p.m., Swapnil Ghike wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 61-65 https://reviews.apache.org/r/14496/diff/2/?file=361683#file361683line61 Instead of asking the user to store the output of a dryrun into a JSON file, should

Re: Review Request 14496: incorporating review feedback

2013-10-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/ --- (Updated Oct. 5, 2013, 6:02 p.m.) Review request for kafka. Summary