Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41472 --- Great cleanup patch! Some minor comments. 1.

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41521 --- Looks good. Just the following minor comment.

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 25, 2014, 9:09 p.m.) Review request for kafka. Bugs:

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

2014-04-24 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 24, 2014, 11:22 p.m.) Review request for kafka. Summary

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

2014-04-23 Thread Guozhang Wang
On April 22, 2014, 10 p.m., Jun Rao wrote: core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines 114-116 https://reviews.apache.org/r/20380/diff/3/?file=564586#file564586line114 For this particular test, resending in the producer could introduce

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

2014-04-22 Thread Guozhang Wang
On April 21, 2014, 10:11 p.m., Neha Narkhede wrote: core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, line 122 https://reviews.apache.org/r/20380/diff/2/?file=560977#file560977line122 Is this check for metadata propagation actually required? It seems to me

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

2014-04-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 22, 2014, 5:43 p.m.) Review request for kafka. Summary

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

2014-04-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41070 ---

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

2014-04-22 Thread Guozhang Wang
On April 22, 2014, 10 p.m., Jun Rao wrote: core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines 114-116 https://reviews.apache.org/r/20380/diff/3/?file=564586#file564586line114 For this particular test, resending in the producer could introduce

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40972 ---

Re: Review Request 20380: Fix KAFKA-1395

2014-04-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40551 ---

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

2014-04-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 16, 2014, 5:11 p.m.) Review request for kafka. Summary

Review Request 20380: Fix KAFKA-1395

2014-04-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- Review request for kafka. Bugs: KAFKA-1395