Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/ --- (Updated April 16, 2014, 6:53 p.m.) Review request for kafka. Bugs:

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-16 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/#review40590 --- Ship it! Ship It! - Joel Koshy On April 16, 2014, 6:53 p.m.,

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-16 Thread Joel Koshy
On April 16, 2014, 6:57 p.m., Joel Koshy wrote: Ship It! Actually, I ran into this: ReplicaManagerTest.scala:51: value tempRelativeDir is not a member of object kafka.utils.TestUtils props.put(log.dir, TestUtils.tempRelativeDir(data).getAbsolutePath) - Joel

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/ --- (Updated April 16, 2014, 7:05 p.m.) Review request for kafka. Bugs:

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-16 Thread Guozhang Wang
On April 16, 2014, 6:57 p.m., Joel Koshy wrote: Ship It! Joel Koshy wrote: Actually, I ran into this: ReplicaManagerTest.scala:51: value tempRelativeDir is not a member of object kafka.utils.TestUtils props.put(log.dir,

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-16 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/#review40600 --- Ship it! Ship It! - Joel Koshy On April 16, 2014, 7:05 p.m.,

Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

2014-04-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/ --- Review request for kafka. Bugs: KAFKA-1323