---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/#review43172
---
Ship it!
Ship It!
- Jay Kreps
On May 15, 2014, 10:19 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/#review43157
---
On May 15, 2014, 8:47 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 201
https://reviews.apache.org/r/21398/diff/4/?file=582079#file582079line201
Instead of a ListNode use a HashSetInteger to avoid the O(N)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/
---
(Updated May 15, 2014, 10:15 p.m.)
Review request for kafka.
Bugs:
On May 15, 2014, 8:47 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 210
https://reviews.apache.org/r/21398/diff/4/?file=582079#file582079line210
Is Node.UNKNOWN better than null?
Also, please
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/#review43122
---
On May 14, 2014, 4:31 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
lines 204-247
https://reviews.apache.org/r/21398/diff/2/?file=580819#file580819line204
Could the two loops be merged into a single loop?
The first
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/
---
(Updated May 14, 2014, 11:24 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/
---
(Updated May 14, 2014, 11:28 p.m.)
Review request for kafka.
Bugs:
On May 13, 2014, 6:37 p.m., Timothy Chen wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java,
line 323
https://reviews.apache.org/r/21398/diff/2/?file=580820#file580820line323
Should we only call forceUpdate once if we get multiple unknown nodes?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/#review42982
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/#review42985
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/
---
(Updated May 13, 2014, 6:19 p.m.)
Review request for kafka.
Bugs: KAFKA-1445
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21398/#review42869
---
14 matches
Mail list logo