---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review84278
---
Thanks for the updated patch. This looks good. I ended up rebasing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated May 18, 2015, 5:29 p.m.)
Review request for kafka.
Bugs: KAFKA-1374
On May 12, 2015, 2:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, line 409
https://reviews.apache.org/r/24214/diff/9/?file=824405#file824405line409
I would suggest one of two options over this (i.e., instead of two
helper methods)
- Inline both
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review83392
---
Sorry for the delay. Overall, this looks good.
As discussed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review68569
---
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Jan. 17, 2015, 6:53 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Jan. 17, 2015, 6:51 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Oct. 3, 2014, 1:22 p.m.)
Review request for kafka.
Bugs: KAFKA-1374
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Oct. 3, 2014, 1:50 p.m.)
Review request for kafka.
Bugs: KAFKA-1374
On Aug. 18, 2014, 5:32 p.m., Joel Koshy wrote:
I should be able to review this later today. However, as Jun also mentioned
can you please run the stress test? When I was working on the original
(WIP) patch it worked but eventually failed (due to various reasons such as
corrupt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Sept. 23, 2014, 4:20 p.m.)
Review request for kafka.
Bugs:
On Aug. 18, 2014, 5:21 p.m., Jun Rao wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, lines 436-438
https://reviews.apache.org/r/24214/diff/3-5/?file=657031#file657031line436
Hmm, I think the original approach of throwing an exception is probably
better. When handling the
On Aug. 18, 2014, 5:32 p.m., Joel Koshy wrote:
I should be able to review this later today. However, as Jun also mentioned
can you please run the stress test? When I was working on the original
(WIP) patch it worked but eventually failed (due to various reasons such as
corrupt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review50901
---
I should be able to review this later today. However, as Jun also
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Aug. 12, 2014, 4:55 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Aug. 12, 2014, 4:57 p.m.)
Review request for kafka.
Bugs:
On Aug. 10, 2014, 11:44 p.m., Jun Rao wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, lines 400-420
https://reviews.apache.org/r/24214/diff/4/?file=657033#file657033line400
Thinking about this a bit more. I am wondering if it would be better if
we introduce a per-topic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review50128
---
core/src/main/scala/kafka/log/LogCleaner.scala
On Aug. 10, 2014, 11:44 p.m., Jun Rao wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, lines 400-420
https://reviews.apache.org/r/24214/diff/4/?file=657033#file657033line400
Thinking about this a bit more. I am wondering if it would be better if
we introduce a per-topic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Aug. 9, 2014, 10:30 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Aug. 9, 2014, 10:37 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
(Updated Aug. 9, 2014, 10:51 a.m.)
Review request for kafka.
Bugs:
On Aug. 6, 2014, 4:29 a.m., Jun Rao wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, lines 500-506
https://reviews.apache.org/r/24214/diff/1/?file=649265#file649265line500
Could we use Compressor.putRecord? Then,we don't have to worry about
the details of the message
On Aug. 6, 2014, 4:29 a.m., Jun Rao wrote:
core/src/main/scala/kafka/log/LogCleaner.scala, lines 500-506
https://reviews.apache.org/r/24214/diff/1/?file=649265#file649265line500
Could we use Compressor.putRecord? Then,we don't have to worry about
the details of the message
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review49611
---
Thanks for the patch. Some comments below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---
Review request for kafka.
Bugs: KAFKA-1374
26 matches
Mail list logo
