Re: Review Request 26564: Patch for KAFKA-1471
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/#review56365 --- Thanks for updating the patch, Ewen. 2 minor comments. Probably worth updating PerfConfig as well as MessageTest - Neha Narkhede On Oct. 10, 2014, 5:43 p.m., Ewen Cheslack-Postava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/ --- (Updated Oct. 10, 2014, 5:43 p.m.) Review request for kafka. Bugs: KAFKA-1471 https://issues.apache.org/jira/browse/KAFKA-1471 Repository: kafka Description --- KAFKA-1471 Add producer unit tests for LZ4 and LZ4HC compression codecs Diffs - clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 79d57f9bf31606ffa5400f2f12356eba84703cc2 core/src/main/scala/kafka/tools/ConsoleProducer.scala 8e9ba0b284671989f87d9c421bc98f5c4384c260 core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 17e2c6e9dfd789acb4b6db37c780c862667e4e11 Diff: https://reviews.apache.org/r/26564/diff/ Testing --- Thanks, Ewen Cheslack-Postava
Re: Review Request 26564: Patch for KAFKA-1471
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/ --- (Updated Oct. 12, 2014, 11:02 p.m.) Review request for kafka. Bugs: KAFKA-1471 https://issues.apache.org/jira/browse/KAFKA-1471 Repository: kafka Description (updated) --- KAFKA-1471 Add producer unit tests for LZ4 and LZ4HC compression codecs; patched by James Oliver Diffs (updated) - clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 79d57f9bf31606ffa5400f2f12356eba84703cc2 core/src/main/scala/kafka/tools/ConsoleProducer.scala 8e9ba0b284671989f87d9c421bc98f5c4384c260 core/src/main/scala/kafka/tools/PerfConfig.scala 129cc013f68d2b89bdfea74a1d9ee26a011791f2 core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 17e2c6e9dfd789acb4b6db37c780c862667e4e11 core/src/test/scala/unit/kafka/message/MessageTest.scala 4837585d03535043a6f25938368988128df9b94a Diff: https://reviews.apache.org/r/26564/diff/ Testing --- Thanks, Ewen Cheslack-Postava
Re: Review Request 26564: Patch for KAFKA-1471
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/#review56368 --- Ship it! Ship It! - Neha Narkhede On Oct. 12, 2014, 11:02 p.m., Ewen Cheslack-Postava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/ --- (Updated Oct. 12, 2014, 11:02 p.m.) Review request for kafka. Bugs: KAFKA-1471 https://issues.apache.org/jira/browse/KAFKA-1471 Repository: kafka Description --- KAFKA-1471 Add producer unit tests for LZ4 and LZ4HC compression codecs; patched by James Oliver Diffs - clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 79d57f9bf31606ffa5400f2f12356eba84703cc2 core/src/main/scala/kafka/tools/ConsoleProducer.scala 8e9ba0b284671989f87d9c421bc98f5c4384c260 core/src/main/scala/kafka/tools/PerfConfig.scala 129cc013f68d2b89bdfea74a1d9ee26a011791f2 core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 17e2c6e9dfd789acb4b6db37c780c862667e4e11 core/src/test/scala/unit/kafka/message/MessageTest.scala 4837585d03535043a6f25938368988128df9b94a Diff: https://reviews.apache.org/r/26564/diff/ Testing --- Thanks, Ewen Cheslack-Postava
Re: Review Request 26564: Patch for KAFKA-1471
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/#review56369 --- Ship it! Ship It! - Neha Narkhede On Oct. 12, 2014, 11:02 p.m., Ewen Cheslack-Postava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/ --- (Updated Oct. 12, 2014, 11:02 p.m.) Review request for kafka. Bugs: KAFKA-1471 https://issues.apache.org/jira/browse/KAFKA-1471 Repository: kafka Description --- KAFKA-1471 Add producer unit tests for LZ4 and LZ4HC compression codecs; patched by James Oliver Diffs - clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 79d57f9bf31606ffa5400f2f12356eba84703cc2 core/src/main/scala/kafka/tools/ConsoleProducer.scala 8e9ba0b284671989f87d9c421bc98f5c4384c260 core/src/main/scala/kafka/tools/PerfConfig.scala 129cc013f68d2b89bdfea74a1d9ee26a011791f2 core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 17e2c6e9dfd789acb4b6db37c780c862667e4e11 core/src/test/scala/unit/kafka/message/MessageTest.scala 4837585d03535043a6f25938368988128df9b94a Diff: https://reviews.apache.org/r/26564/diff/ Testing --- Thanks, Ewen Cheslack-Postava
Review Request 26564: Patch for KAFKA-1471
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26564/ --- Review request for kafka. Bugs: KAFKA-1471 https://issues.apache.org/jira/browse/KAFKA-1471 Repository: kafka Description --- KAFKA-1471 Add producer unit tests for LZ4 and LZ4HC compression codecs Diffs - clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 79d57f9bf31606ffa5400f2f12356eba84703cc2 core/src/main/scala/kafka/tools/ConsoleProducer.scala 8e9ba0b284671989f87d9c421bc98f5c4384c260 core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 17e2c6e9dfd789acb4b6db37c780c862667e4e11 Diff: https://reviews.apache.org/r/26564/diff/ Testing --- Thanks, Ewen Cheslack-Postava
