---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review83433
---
Ship it!
Minor comments - I will address these on check-in.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated May 12, 2015, 9:29 p.m.)
Review request for kafka.
Bugs: KAFKA-1660
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review82402
---
Ship it!
Ship It!
- Jay Kreps
On April 30, 2015, 12:37 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 29, 2015, 11:58 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 30, 2015, 12:37 a.m.)
Review request for kafka.
Bugs:
On April 20, 2015, 5:30 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 157
https://reviews.apache.org/r/31850/diff/9/?file=931821#file931821line157
Read locks are very expensive. I am pretty worried about
On April 20, 2015, 5:30 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 526
https://reviews.apache.org/r/31850/diff/9/?file=931818#file931818line526
I cleaned up this javadoc a little bit to try to simplify things. With
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 21, 2015, 12:38 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review80753
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 16, 2015, 6:35 p.m.)
Review request for kafka.
Bugs:
On April 11, 2015, 8:02 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 155
https://reviews.apache.org/r/31850/diff/8/?file=923927#file923927line155
This scheme is clever but non-obvious, is there a simpler
On April 11, 2015, 8:02 p.m., Jay Kreps wrote:
Thanks for the review, Jay. Please see the reply below.
On April 11, 2015, 8:02 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 530
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 10, 2015, 10:09 p.m.)
Review request for kafka.
Bugs:
On April 10, 2015, 4:36 p.m., Joel Koshy wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 394
https://reviews.apache.org/r/31850/diff/7/?file=921104#file921104line394
I was trying to find a case where it wouldn't work, but I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review79761
---
Ship it!
- Guozhang Wang
On April 10, 2015, 10:09 p.m., Jiangjie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review79379
---
On April 8, 2015, 6:36 p.m., Joel Koshy wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 153
https://reviews.apache.org/r/31850/diff/6/?file=920399#file920399line153
Thanks for catching this issue, but can you explain it more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 8, 2015, 9:01 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated April 8, 2015, 1:18 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review79063
---
Thanks for the patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review79107
---
On April 7, 2015, 1:28 a.m., Joel Koshy wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java,
line 362
https://reviews.apache.org/r/31850/diff/5/?file=908540#file908540line362
As you explained offline, the sender does not have access to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated March 27, 2015, 11:35 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated March 25, 2015, 5:55 p.m.)
Review request for kafka.
Bugs:
On March 9, 2015, 6:37 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 418
https://reviews.apache.org/r/31850/diff/2/?file=86#file86line418
This is not related to this ticket, but I think we can just throw e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review75968
---
Ship it!
LGTM. Just a minor comment on one of your replies.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review75731
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated March 9, 2015, 7:56 p.m.)
Review request for kafka.
Bugs:
On March 9, 2015, 6:37 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 565
https://reviews.apache.org/r/31850/diff/2/?file=86#file86line565
Could metrics.close() be called simultaneously?
I think so. It is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review75742
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
Review request for kafka.
Bugs: KAFKA-1660
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated March 9, 2015, 4:07 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/
---
(Updated March 9, 2015, 4:14 a.m.)
Review request for kafka.
Bugs:
33 matches
Mail list logo
