Re: Review Request 32650: Patch for KAFKA-2000

2015-05-06 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review82775 --- Thanks for the updated patch.

Re: Review Request 32650: Patch for KAFKA-2000

2015-05-03 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/ --- (Updated May 3, 2015, 5:39 p.m.) Review request for kafka. Bugs: KAFKA-2000

Re: Review Request 32650: Patch for KAFKA-2000

2015-05-03 Thread Sriharsha Chintalapani
On April 23, 2015, 9:51 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/OffsetManager.scala, line 124 https://reviews.apache.org/r/32650/diff/1/?file=909897#file909897line124 A safer fix is to proactively purge as part of UpdateMetadataRequest - i.e., removePartitionInfo

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review81413 --- core/src/main/scala/kafka/server/OffsetManager.scala

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-23 Thread Joel Koshy
On April 23, 2015, 9:51 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/OffsetManager.scala, line 124 https://reviews.apache.org/r/32650/diff/1/?file=909897#file909897line124 A safer fix is to proactively purge as part of UpdateMetadataRequest - i.e., removePartitionInfo

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-21 Thread Joel Koshy
On April 20, 2015, 11:18 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/OffsetManager.scala, line 124 https://reviews.apache.org/r/32650/diff/1/?file=909897#file909897line124 I think there is an issue in relying on the metadata cache mainly due to start-up. E.g., when

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-20 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review80857 --- core/src/main/scala/kafka/server/OffsetManager.scala

Review Request 32650: Patch for KAFKA-2000

2015-03-30 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/ --- Review request for kafka. Bugs: KAFKA-2000

Re: Review Request 32650: Patch for KAFKA-2000

2015-03-30 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review78310 --- Ship it! Very nice fix :) - Gwen Shapira On March 30, 2015,

Re: Review Request 32650: Patch for KAFKA-2000

2015-03-30 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review78337 --- This might be out of scope for this JIRA, but I think if the