---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated June 3, 2015, 10:59 p.m.)
Review request for kafka.
Bugs: 1928 and
On June 1, 2015, 11:52 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/KafkaConfig.scala, line 498
https://reviews.apache.org/r/33065/diff/17/?file=975403#file975403line498
It's better to define it of type LIST, in the same way as the client.
Then, we can use
On June 1, 2015, 11:15 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
332
https://reviews.apache.org/r/33065/diff/17/?file=975364#file975364line332
This is less of a connection id and more of a formatted connection,
right?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review86117
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review86118
---
Ship it!
Looks good to me.
- Jay Kreps
On May 31, 2015, 9:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review86095
---
Thanks for the latest patch. A few more minor comments below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 31, 2015, 9:49 p.m.)
Review request for kafka.
Bugs: 1928 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review85360
---
Ship it!
Thanks for the big patch Gwen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review85412
---
core/src/main/scala/kafka/network/SocketServer.scala
On May 27, 2015, 6:44 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 109
https://reviews.apache.org/r/33065/diff/16/?file=971264#file971264line109
Agreed with Joel's point. We should probably just create a single
Metrics object in KafkaServer and
On May 27, 2015, 6:44 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 109
https://reviews.apache.org/r/33065/diff/16/?file=971264#file971264line109
Agreed with Joel's point. We should probably just create a single
Metrics object in KafkaServer and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review85180
---
Ship it!
Thanks for the latest patch. +1 other than the following
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 24, 2015, 4:53 p.m.)
Review request for kafka.
Bugs: 1928 and
On May 21, 2015, 2:11 a.m., Guozhang Wang wrote:
core/src/main/scala/kafka/network/RequestChannel.scala, line 110
https://reviews.apache.org/r/33065/diff/15/?file=965056#file965056line110
This would result in the following log entry:
TRACE Completed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 20, 2015, 10:42 a.m.)
Review request for kafka.
Bugs: 1928 and
On May 19, 2015, 11:34 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 431
https://reviews.apache.org/r/33065/diff/14/?file=963545#file963545line431
We probably just want to catch Exception. For unexpected error, we will
just let it propagate and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review84536
---
Thanks for the latest patch. Just two new minor comments and a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review84649
---
core/src/main/scala/kafka/network/RequestChannel.scala
On May 18, 2015, 4:53 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
115
https://reviews.apache.org/r/33065/diff/12/?file=962798#file962798line115
Do we need to turn this into a map? NetworkReceive already has the
connection id.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 19, 2015, 8:26 a.m.)
Review request for kafka.
Bugs: 1928 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review84398
---
Thanks for the latest patch. Only a few more minor comments.
Also,
On May 18, 2015, 4:53 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Send.java, line 56
https://reviews.apache.org/r/33065/diff/12/?file=962799#file962799line56
This needs to be long since NetworkSend always includes a size buffer,
plus the payload
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 18, 2015, 2:58 p.m.)
Review request for kafka.
Bugs: 1928 and
On May 15, 2015, 10:12 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/MultiSend.java, line
74
https://reviews.apache.org/r/33065/diff/11/?file=961086#file961086line74
Actually, with MultiSend, we will be sending a 4-byte size plus the
payload, the
On May 15, 2015, 10:12 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 354
https://reviews.apache.org/r/33065/diff/11/?file=961124#file961124line354
I guess we will make use of this in a followup patch?
Actually, I think its no longer needed and can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 18, 2015, 3:56 p.m.)
Review request for kafka.
Bugs: 1928 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review84158
---
Thanks for the latest patch. Looks good. Just a few minor comments
On May 15, 2015, 10:12 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java,
lines 159-162
https://reviews.apache.org/r/33065/diff/11/?file=961076#file961076line159
We don't need this since the idle conenctions only need to be closed on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 15, 2015, 7:30 a.m.)
Review request for kafka.
Bugs: 1928 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review83959
---
Thanks for the patch. There seem to be some compilation errors.
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 455
https://reviews.apache.org/r/33065/diff/4/?file=947565#file947565line455
This is just registering for reads, not for writes, right?
Maybe I misunderstood, but it looks like
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
311-315
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line311
In this case, we should probably just propagate the exception and
potentially
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 14, 2015, 9:30 p.m.)
Review request for kafka.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review83841
---
core/src/main/scala/kafka/network/SocketServer.scala
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
311-315
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line311
In this case, we should probably just propagate the exception and
potentially
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
311-315
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line311
In this case, we should probably just propagate the exception and
potentially
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 14, 2015, 9:51 p.m.)
Review request for kafka.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 15, 2015, 12:07 a.m.)
Review request for kafka.
Changes
---
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
198-199
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line198
Could we just iterate the keySet directly instead of making a copy
first?
We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 12, 2015, 9 a.m.)
Review request for kafka.
Summary (updated)
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java,
lines 55-64
https://reviews.apache.org/r/33065/diff/4/?file=947526#file947526line55
Since we always use a 4 byte size, perhaps we should make both
remaining()
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 12, 2015, 9:58 a.m.)
Review request for kafka.
Bugs: 1928 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review82347
---
On April 18, 2015, 12:49 a.m., Jun Rao wrote:
core/src/main/scala/kafka/api/FetchResponse.scala, lines 66-72
https://reviews.apache.org/r/33065/diff/1/?file=922627#file922627line66
I am wondering if we need both completed() and remaining() in Send. It
seems that one of the two is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review82625
---
Thanks for the patch. Looks great overall! Some comments below.
On May 1, 2015, 9:25 p.m., Jay Kreps wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 382
https://reviews.apache.org/r/33065/diff/3/?file=946988#file946988line382
Beautiful! So much deleted code!
Haha :) Yeah, I love how minimal SocketServer became.
- Gwen
On April 18, 2015, 12:49 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java,
line 55
https://reviews.apache.org/r/33065/diff/1/?file=922619#file922619line55
Do you know why the return is changed from int to long?
writeTo() and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 1, 2015, 10:45 p.m.)
Review request for kafka.
Bugs: KAFKA-1928
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review82281
---
I did a high level pass. On the whole I think this is awesome! I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 1, 2015, 12:48 a.m.)
Review request for kafka.
Bugs: KAFKA-1928
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review80761
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review80557
---
Took a quick look. Overall, looks good. A few comments below.
52 matches
Mail list logo
