Re: Review Request 33196: Patch for KAFKA-2123

2015-06-04 Thread Jason Gustafson
On May 31, 2015, 9:10 p.m., Guozhang Wang wrote: Thanks for the explanation Ewen. I agree that a delayed scheduler would be a good fit here, but was originally more concerned about the complexity we introduced by adding two queues (one for delayed actions and another for handling

Re: Review Request 33196: Patch for KAFKA-2123

2015-06-04 Thread Ewen Cheslack-Postava
On May 31, 2015, 9:10 p.m., Guozhang Wang wrote: Thanks for the explanation Ewen. I agree that a delayed scheduler would be a good fit here, but was originally more concerned about the complexity we introduced by adding two queues (one for delayed actions and another for handling

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-31 Thread Guozhang Wang
On May 31, 2015, 9:10 p.m., Guozhang Wang wrote: Thanks for the explanation Ewen. I agree that a delayed scheduler would be a good fit here, but was originally more concerned about the complexity we introduced by adding two queues (one for delayed actions and another for handling

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/#review85920 --- Thanks for the explanation Ewen. I agree that a delayed scheduler

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-29 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- (Updated May 29, 2015, 6:11 p.m.) Review request for kafka. Bugs: KAFKA-2123

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-29 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/#review85824 ---

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-04 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- (Updated May 4, 2015, 4:39 p.m.) Review request for kafka. Bugs: KAFKA-2123

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/#review82448 ---

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-04 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- (Updated May 5, 2015, 5:51 a.m.) Review request for kafka. Bugs: KAFKA-2123

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-04 Thread Ewen Cheslack-Postava
On May 5, 2015, 1:39 a.m., Guozhang Wang wrote: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java, lines 186-188 https://reviews.apache.org/r/33196/diff/4/?file=949010#file949010line186 Maybe we can combine the commitOffsetRequests and

Re: Review Request 33196: Patch for KAFKA-2123

2015-05-01 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- (Updated May 2, 2015, 2:33 a.m.) Review request for kafka. Bugs: KAFKA-2123

Review Request 33196: Patch for KAFKA-2123

2015-04-14 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- Review request for kafka. Bugs: KAFKA-2123