Re: Review Request 34608: Patch for KAFKA-2217

> On May 24, 2015, 7:16 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 226 > > > > > > One drawback to this is that we're now constantly reallocat

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/ --- (Updated May 27, 2015, 10:52 p.m.) Review request for kafka. Bugs: KAFKA-2217

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/#review85245 --- I noticed one minor issue with a metrics sensor, but otherwise LGTM

Re: Review Request 34608: Patch for KAFKA-2217

> On May 24, 2015, 7:16 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 226 > > > > > > One drawback to this is that we're now constantly reallocat

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/ --- (Updated May 26, 2015, 7:58 p.m.) Review request for kafka. Bugs: KAFKA-2217

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/#review85192 --- Thanks for the patch. Looks good. Just a couple of minor comments be

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/ --- (Updated May 26, 2015, 4:38 p.m.) Review request for kafka. Bugs: KAFKA-2217

Re: Review Request 34608: Patch for KAFKA-2217

> On May 24, 2015, 7:16 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 226 > > > > > > One drawback to this is that we're now constantly reallocat

Re: Review Request 34608: Patch for KAFKA-2217

> On May 24, 2015, 7:16 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 226 > > > > > > One drawback to this is that we're now constantly reallocat

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/ --- (Updated May 25, 2015, 5:46 p.m.) Review request for kafka. Bugs: KAFKA-2217

Re: Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/#review85101 --- clients/src/main/java/org/apache/kafka/common/network/Selector.java

Review Request 34608: Patch for KAFKA-2217

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/ --- Review request for kafka. Bugs: KAFKA-2217 https://issues.apache.org/jira/b