Re: Review Request 35791: Patch for KAFKA-2298

2015-07-07 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review90847 --- Ship it! Ship It! - Joel Koshy On June 24, 2015, 8 p.m., Dong

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Dong Lin
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Jason Gustafson
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Jason Gustafson
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Dong Lin
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- (Updated June 24, 2015, 8 p.m.) Review request for kafka. Bugs: KAFKA-2298

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review89241 --- Ship it! Ship It! - Jason Gustafson On June 24, 2015, 8 p.m.,

Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- Review request for kafka. Bugs: KAFKA-2298

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review89010 ---

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Jason Gustafson
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/ --- (Updated June 24, 2015, 1:48 a.m.) Review request for kafka. Bugs:

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Joel Koshy
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote: clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 282 https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282 Do you think we should just move the disconnected.add() into the close