Re: Review Request 36244: Patch for KAFKA-2312

2015-07-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review91519 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 5 a.m., Tim B

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-13 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review91514 --- Ship it! Ship It! - Ismael Juma On July 7, 2015, 5 a.m., Tim Bro

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-13 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review91488 --- Ship it! LGTM - Jason Gustafson On July 7, 2015, 5 a.m., Tim Bro

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-06 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review90651 --- Ship it! Performance-wise, it's a micro-optimization that probably

Review Request 36244: Patch for KAFKA-2312

2015-07-06 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/ --- Review request for kafka. Bugs: KAFKA-2312 https://issues.apache.org/jira/b