---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92282
---
Ship it!
Ship It!
- Edward Ribeiro
On Julho 20, 2015, 5:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92296
---
Ship it!
Ship It!
- Ashish Singh
On July 20, 2015, 5:37 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92276
---
core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)
On July 20, 2015, 5:27 p.m., Ashish Singh wrote:
LGTM, just a small comment.
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92276
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
(Updated July 20, 2015, 5:37 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92323
---
Ship it!
LGTM.
Just a small nit.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92327
---
Ship it!
Ship It!
- Grant Henke
On July 20, 2015, 9:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
(Updated July 20, 2015, 9:48 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
Review request for kafka.
Bugs: KAFKA-2337
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
(Updated July 17, 2015, 4:17 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92092
---
core/src/main/scala/kafka/common/Topic.scala (lines 53 - 54)
On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/common/Topic.scala, line 64
https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64
*Maybe* this method name could be renamed to 'collide' to make it more
like a verb instead of a
On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/common/Topic.scala, line 64
https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64
*Maybe* this method name could be renamed to 'collide' to make it more
like a verb instead of a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92089
---
core/src/main/scala/kafka/common/Topic.scala (line 64)
On July 17, 2015, 4:05 p.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/common/Topic.scala, lines 53-54
https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line53
This method name is sort of a misnomer is a it is checking for special
characters that could lead
On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/common/Topic.scala, line 64
https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64
*Maybe* this method name could be renamed to 'collide' to make it more
like a verb instead of a
16 matches
Mail list logo
