Re: Review Request 36681: Patch for KAFKA-2275

> On July 28, 2015, 10:19 p.m., Guozhang Wang wrote: > > clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java, > > line 42 > > > > > > HashMap is no longer used anywhere, and running che

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/#review93361 --- Ship it! clients/src/test/java/org/apache/kafka/clients/consumer/i

Re: Review Request 36681: Patch for KAFKA-2275

> On July 23, 2015, 7:19 a.m., Ashish Singh wrote: > > clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java, > > line 173 > > > > > > getAllTopics is a blocking call and we need to send

Re: Review Request 36681: Patch for KAFKA-2275

> On July 23, 2015, 7:19 a.m., Ashish Singh wrote: > > clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java, > > line 173 > > > > > > getAllTopics is a blocking call and we need to send

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/ --- (Updated July 23, 2015, 4:34 p.m.) Review request for kafka. Bugs: KAFKA-2275

Re: Review Request 36681: Patch for KAFKA-2275

> On July 23, 2015, 7:19 a.m., Ashish Singh wrote: > > clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java, > > line 173 > > > > > > getAllTopics is a blocking call and we need to send

Re: Review Request 36681: Patch for KAFKA-2275

> On July 23, 2015, 7:19 a.m., Ashish Singh wrote: > > core/src/test/scala/integration/kafka/api/ConsumerTest.scala, line 198 > > > > > > I don't think it is an issue. Hope it's OK to drop the issue. Thanks > > for

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/#review92730 --- clients/src/test/java/org/apache/kafka/clients/consumer/internals/F

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/#review92700 --- Ship it! Just one question on the unit test. Otherwise, LGTM. cli

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/#review92696 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/F

Re: Review Request 36681: Patch for KAFKA-2275

> On July 22, 2015, 4:43 p.m., Jason Gustafson wrote: > > Hey Ashish, this looks pretty good to me. Just some minor comments. Thanks for the review! Addressed your concerns. > On July 22, 2015, 4:43 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/intern

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/ --- (Updated July 22, 2015, 11:09 p.m.) Review request for kafka. Bugs: KAFKA-227

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/#review92644 --- Ship it! LGTM. I think we can checkin after Jason's comments get ad

Re: Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/#review92604 --- Hey Ashish, this looks pretty good to me. Just some minor comments.

Review Request 36681: Patch for KAFKA-2275

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36681/ --- Review request for kafka. Bugs: KAFKA-2275 https://issues.apache.org/jira/b