Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

I am closing this vote. The KIP is accepted with 3 non-binding (Ted, Bill, Satish) and 3 binding (Guozhang, Damian, Matthias) votes. Thanks a lot for the discussion and voting. -Matthias On 1/16/18 10:08 AM, Matthias J. Sax wrote: > ATM, StreamsConfig is immutable. Thus, it's just boiler

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

ATM, StreamsConfig is immutable. Thus, it's just boiler plate code for the user. If we really add a builder pattern or change StreamsConfig, we can update the API accordingly. We will need a KIP for those changes anyway. But for now, it seems to be best to avoid boiler plate if possible. Just my

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Why not just have a StreamsConfig constructor that takes a Properties object? This has a few advantages. Firstly, because it's purely additive, it doesn't create any deprecated functions or compatibility issues that we have to clean up later. Secondly, if we decide to do something

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Thanks for updating the KIP. I am recasting my vote +1 (binding). -Matthias On 1/13/18 4:30 AM, Boyang Chen wrote: > Hey Matt and Guozhang, > > > I have already updated the pull > request: https://github.com/apache/kafka/pull/4354 > > and the > KIP:  >

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Thanks for the KIP! +1 On Sat, 13 Jan 2018 at 12:30 Boyang Chen wrote: > Hey Matt and Guozhang, > > > I have already updated the pull request: > https://github.com/apache/kafka/pull/4354 > > and the KIP: >

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Hey Matt and Guozhang, I have already updated the pull request: https://github.com/apache/kafka/pull/4354 and the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-245%3A+Use+Properties+instead+of+StreamsConfig+in+KafkaStreams+constructor to reflect the change proposed by

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Boyang, what is the status of this KIP? The release plan for 1.1 was just announced and we like to get this KIP into the release. Thx. -Matthias On 1/2/18 11:18 AM, Guozhang Wang wrote: > Boyang, > > Thanks for the proposed change, the wiki page lgtm. One minor comment > otherwise I'm +1: >

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Boyang, Thanks for the proposed change, the wiki page lgtm. One minor comment otherwise I'm +1: For the new API, we now also have a constructor that accepts both a clientSupplier and a Time, so we should consider having four overloads in total: // New API (using Properties) public

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Thanks for the KIP, +1 from me. On Wed, Dec 27, 2017 at 7:42 AM, Bill Bejeck wrote: > Thanks for the KIP. +1 for me. > > On Tue, Dec 26, 2017 at 6:22 PM Ted Yu wrote: > > > +1 from me as well. > > > > On Tue, Dec 26, 2017 at 10:41 AM, Matthias J. Sax

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Thanks for the KIP. +1 for me. On Tue, Dec 26, 2017 at 6:22 PM Ted Yu wrote: > +1 from me as well. > > On Tue, Dec 26, 2017 at 10:41 AM, Matthias J. Sax > wrote: > > > Thanks for the KIP Boyang! > > > > I don't have any further comments. > > > > +1

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

+1 from me as well. On Tue, Dec 26, 2017 at 10:41 AM, Matthias J. Sax wrote: > Thanks for the KIP Boyang! > > I don't have any further comments. > > +1 from me. > > @Ted: This is a rather simple KIP, thus, skipping the DISCUSS thread > seems ok to me. > > > > -Matthias >

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Thanks for the KIP Boyang! I don't have any further comments. +1 from me. @Ted: This is a rather simple KIP, thus, skipping the DISCUSS thread seems ok to me. -Matthias @Boyang: it's recommended to use this format for the subject "[VOTE] KIP-245: ..." Same for DISCUSS threads. People are

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Normally a DISCUSS thread precedes VOTE thread so that people have ample time examining the proposal. Original message From: Boyang Chen Date: 12/26/17 1:22 AM (GMT-07:00) To: dev@kafka.apache.org Subject: Vote for KIP-245: Use Properties instead of

Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

Hi there, I'm Boyang who is a newbie contributor to Kafka. I would like to start a vote for the KIP-245: https://cwiki.apache.org/confluence/display/KAFKA/KIP-245%3A+Use+Properties+instead+of+StreamsConfig+in+KafkaStreams+constructor This is linked with JIRA: