Re: Admin script issue (java mem)

2013-08-15 Thread Charles Moulliard
Hi JB, Karaf and admin scripts both use setenv : RedHat-MacBook:bin chmoulli$ more admin | grep setenv # Sourcing environment settings for karaf similar to tomcats setenv if [ -f "$DIRNAME/setenv" ]; then . "$DIRNAME/setenv" RedHat-MacBook:bin chmoulli$ more karaf | grep setenv # Sourcing envir

Re: Some thoughts around adding security for Karaf Shell Commands

2013-08-15 Thread Freeman Fang
+1 for this proposal. I like the idea that we needn't change current commands code, but hack it through service registry hooks. - Freeman(Yue) Fang Red Hat, Inc. FuseSource is now part of Red Hat Web: http://fusesource.com | http://www.redhat.com/ Twitter: freemanfang Blog: http://f

Re: Some thoughts around adding security for Karaf Shell Commands

2013-08-15 Thread Jean-Baptiste Onofré
OSGi already provides the security module for that, and it's what David proposed (to "leverage" the services security). An extension with Shiro (expecially now that we have Pax Shiro ;)) is a good idea. Regards JB On 08/15/2013 10:16 PM, Christian Schneider wrote: I like the idea of adding

Re: Some thoughts around adding security for Karaf Shell Commands

2013-08-15 Thread Christian Schneider
I like the idea of adding permissions to the commands. I wonder though if this is perhaps a more general problem that not only affects commands. So how about adding a generic permission check for services? For example I would like to use the @RolesAllowed annotation to couple roles or permissi

[RESULT][VOTE] Switch from svn to git

2013-08-15 Thread Jean-Baptiste Onofré
Hi all, This vote has passed with the following result: +1 (binding): Andreas Pieber, Lukasz Dywicki, Achim Nierbeck, Jamie Goodyear, Ioannis Canellos, Freeman Fang, Guillaume Nodet, Jean-Baptiste Onofré +1 (non-binding): Lukaasz Dywicki, Filippo Balicchia, Christoph Gritschenberger, Charles

Re: [VOTE] Switch from svn to git

2013-08-15 Thread Jean-Baptiste Onofré
+1 (binding) Regards JB On 06/25/2013 11:12 AM, Jean-Baptiste Onofré wrote: Hi all, to follow the discussion that we had some weeks ago, I start here a formal vote to migrate our scm from svn to git. Please vote to approve this switch: [ ] +1 Approve the switch (from svn to git) [ ] -1 Do no

Re: Some thoughts around adding security for Karaf Shell Commands

2013-08-15 Thread Jean-Baptiste Onofré
Hi David, Your proposal looks good. I would just add a couple of other features, like command scope management (used for the sub-shell on trunk especially). I have your patch/pull request on my machine. I gonna review it and get back to you. Thanks ! Regards JB On 08/15/2013 04:26 PM, dav...

Some thoughts around adding security for Karaf Shell Commands

2013-08-15 Thread davidb
Hi all, In the context of KARAF-2442 I started looking at securing the commands in the shell. I wanted to do something similar to what I did for the JMX access (KARAF-2435) in that this should be configurable by a Karaf administrator. I also really wanted a generic solution that would work with al