[GitHub] karaf pull request #275: KARAF-4917 Support dynamicaliy registered configura...

2017-01-04 Thread zregvart
Github user zregvart closed the pull request at:

https://github.com/apache/karaf/pull/275


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] karaf pull request #275: KARAF-4917 Support dynamicaliy registered configura...

2017-01-03 Thread zregvart
GitHub user zregvart opened a pull request:

https://github.com/apache/karaf/pull/275

KARAF-4917 Support dynamicaliy registered configurations in RBAC

When adding configuration at runtime through
`ConfigurationAdmin#createFactoryConfiguration` Apache Felix appends
random UUID to the Configuration PID [1][2].

In order for those to be considered by `getRequiredRoles` that random 
UUID needs to be removed in comparison performed by `getGeneralPid`.

[1] 
https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L397-L400
[2] 
https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L1093-L1137

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zregvart/karaf master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/karaf/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #275


commit 0dbf67cbedf2e77a926121fedc506433ee43d21b
Author: Zoran Regvart <zo...@regvart.com>
Date:   2017-01-03T18:16:33Z

Support dynamic configuration from ConfigAdmin

When adding configuration at runtime through
ConfigurationAdmin#createFactoryConfiguration Apache Felix appends
random UUID to the Configuration PID [1][2]. In order for those to be
considered by `getRequiredRoles` that random UUID needs to be removed in
comparison performed by `getGeneralPid`.

[1] 
https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L397-L400
[2] 
https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L1093-L1137




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---