Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Miroslav Beranič
Ah, this is it. I was always compiling with -Pfastinstall ... Thanks Rgds, Miroslav V V tor., 11. sep. 2018 ob 11:01 je oseba Jean-Baptiste Onofré < j...@nanthrax.net> napisala: > Hi, > > Jenkins is doing the same as local. > > Just do a complete: > > mvn clean install -Prat > > you will

Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Jean-Baptiste Onofré
Hi, Jenkins is doing the same as local. Just do a complete: mvn clean install -Prat you will have the same. Regards JB On 11/09/2018 10:58, Miroslav Beranič wrote: > Hi François, > > I have to be logged in to access >

Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Miroslav Beranič
Hi François, I have to be logged in to access https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ Is registration open or I need invite? I did not see a registration form. But more important: How do I compile locally in a way, to have this error

Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Jean-Baptiste Onofré
Hi, Catcha. I will provide my comments directly in the PR. Regards JB On 11/09/2018 09:12, Miroslav Beranič wrote: > Hi JB, > > yes, I know. I need Quartz API, so this was my main motivation. I guess not > all changes are valid. > Open for any suggestion, let me know. > > Regards, > Miroslav

Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Miroslav Beranič
Hi François, thanks! Regards, Miroslav V V tor., 11. sep. 2018 ob 08:46 je oseba Francois Papon < francois.pa...@openobject.fr> napisala: > Hi, > > You are missing the Apache License header in files : > > 4 Unknown Licenses > > * > > Files

Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Jean-Baptiste Onofré
Hi, The ASF headers are missing. By the way, I see a lot of incoherent changes here and not good IMHO. I will do a complete review. Regards JB On 11/09/2018 08:35, Miroslav Beranič wrote: > Hi, > > I've subscribed to dev mailing list. > > I've submitted a pull request at

Re: PR608 - Updated Scheduler feature to support persistence - Failed

2018-09-11 Thread Francois Papon
Hi, You are missing the Apache License header in files : 4 Unknown Licenses * Files with unapproved licenses: scheduler/src/main/java/org/apache/karaf/scheduler/SchedulerStorage.java