[GitHub] karaf pull request #273: Remove duplicate copy resource step

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/karaf/pull/273


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] karaf pull request #273: Remove duplicate copy resource step

[ChristianLutz]

GitHub user ChristianLutz opened a pull request:

https://github.com/apache/karaf/pull/273

Remove duplicate copy resource step

Hello,

In the provided example poms, resources will be copied twice first with 
`resource` tag and second via the `maven-resources-plugin`. The second copy 
call had been started after `karaf-assembly` execution. 

```[INFO] Scanning for projects...
[INFO]
[INFO] 

[INFO] Building server 4.2-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ server ---
[INFO] Deleting C:\Projekte\App\server\target
[INFO]
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
server ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 11 resources
[INFO]
[INFO] --- karaf-maven-plugin:4.0.7:assembly (default-assembly) @ server ---
..
[INFO]
[INFO] --- maven-resources-plugin:2.7:resources (process-resources) @ 
server ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 11 resources
[INFO]
[INFO] --- karaf-maven-plugin:4.0.7:archive (default-archive) @ server 
---```

After the changing the resources will only copied once.

```[INFO] Scanning for projects...
[INFO]
[INFO] 

[INFO] Building server 4.2-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ server ---
[INFO] Deleting C:\Projekte\App\server\target
[INFO]
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
server ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 11 resources
[INFO]
[INFO] --- karaf-maven-plugin:4.0.7:assembly (default-assembly) @ server ---
..
[INFO]
[INFO] --- karaf-maven-plugin:4.0.7:archive (default-archive) @ server 
---



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianLutz/karaf master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/karaf/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #273


commit 832a68cf4bc30620570cdabf32ea0301c8274322
Author: Christian 
Date:   2016-12-19T09:54:54Z

Remove duplicate copy resource step

In the provided example poms, resources will be copied twice once with 
-resource- tag and second via the maven-resources-plugin. And the second copy 
call had been started after karaf-assembly execution. So it was also to late.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---