Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toshiya Kobayashi
All merged. Thanks! Toshiya On Thu, May 8, 2025 at 7:58 PM Toshiya Kobayashi wrote: > I got approvals from Toni and Mario. So I'll go ahead. > > > Given that ideally we want preserve history and the concepts of changes > > already been reviewed and approved, I’d push directly the changes > with

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toshiya Kobayashi
I got approvals from Toni and Mario. So I'll go ahead. > Given that ideally we want preserve history and the concepts of changes > already been reviewed and approved, I’d push directly the changes without a > PR. Okay, I'll go for a direct push next time. This time, I have already started the wo

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toshiya Kobayashi
Btw, I'm setting reviewers (Toni, Mario, Dominik, Alex, Yeser) on the split PRs. If at least two of the reviewers are okay with the original PR ( https://github.com/apache/incubator-kie-docs/pull/4545), I can assume that I get approvals on the split PRs, so I would merge them immediately without bo

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Alex Porcelli
Toshiya, Given that ideally we want preserve history and the concepts of changes already been reviewed and approved, I’d push directly the changes without a PR. Worst case, changes can always been reverted - Alex On Thu, May 8, 2025 at 5:38 AM Toni Rikkola wrote: > Go ahead. It is an isolate

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toni Rikkola
Go ahead. It is an isolated and new folder. If there are issues they are easier fixed than it is to get these in any other way. Toni On Thu, May 8, 2025 at 12:24 PM Toshiya Kobayashi < toshiyakobaya...@gmail.com> wrote: > Btw, I'm setting reviewers (Toni, Mario, Dominik, Alex, Yeser) on the spli

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toshiya Kobayashi
Thank you for the suggestion, Fabrizio. I have started the split PRs as I thought that 10 PRs is an acceptable workload. Of course, it's worth discussing the exceptional procedure, so we will be ready for a future similar case. Thanks, Toshiya On Thu, May 8, 2025 at 5:09 PM Fabrizio Antonangeli

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Fabrizio Antonangeli
Otherwise, if the PR is already reviewed and people agree, I think merging manually (without squashing) and push directly on `main` without GH Web, can be an easier option. I would suggest keeping a copy of the current `main` branch, to be safe, as the past git history will change. This way you av

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toshiya Kobayashi
> I'm going to split the PR to 10 PRs like this... https://github.com/apache/incubator-kie-docs/pull/4550 On Thu, May 8, 2025 at 4:44 PM Toshiya Kobayashi wrote: > Ouch, there is a severe limitation: > > > https://docs.github.com/en/repositories/creating-and-managing-repositories/repository-lim

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-08 Thread Toshiya Kobayashi
Ouch, there is a severe limitation: https://docs.github.com/en/repositories/creating-and-managing-repositories/repository-limits#rebase-limits Rebase limits === Merging a pull request using the "Rebase and merge" option is limited to 100 commits. If you have a pull request with more than 100 comm

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-07 Thread Toshiya Kobayashi
I posted the steps to move the commit history. https://github.com/apache/incubator-kie-docs/pull/4545#issuecomment-2861255969 However, I found that the PR cannot "Rebase and merge" in github UI, even though it has been rebased with upstream/main locally. Probably the steps are okay for other docs

Re: [HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-07 Thread Tiago Bento
Thank you Toshiya! Great initiative. Do you think this PR is enough for people doing the same for other docs? Maybe some pointers on how you were able to keep the commit history, for example? Thanks!! On Wed, May 7, 2025 at 3:02 AM Toshiya Kobayashi wrote: > > Hi all, > > I have filed a PR to mov

[HEADS-UP] drools-docs moves under incubator-kie-docs

2025-05-07 Thread Toshiya Kobayashi
Hi all, I have filed a PR to move incubator-kie-drools/drools-docs under incubator-kie-docs in order to resolve a license issue. https://github.com/apache/incubator-kie-docs/pull/4545 Once merged, I will remove drools-docs from incubator-kie-drools:main. This is just a heads-up and I hope it's