[ https://issues.apache.org/jira/browse/KNOX-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851955#comment-15851955 ]
Sandeep More edited comment on KNOX-861 at 2/3/17 7:53 PM: ----------------------------------------------------------- Looking at the code it looks like only one validator can be used as of now, it might be be a good enhancement if we can use multiple validators. for e.g. PreAuthService.getValidator() could return List<PreAuthValidator> then AbstractPreAuthFederationFilter.isValid() method can iterate over all validators and amke sure they are valid. Just a thought ! -- This probably should be a separate Jira, putting it here as a mental dump. was (Author: smore): Looking at the code it looks like only one validator can be used as of now, it might be be a good enhancement if we can use multiple validators. for e.g. PreAuthService.getValidator() could return List<PreAuthValidator> then AbstractPreAuthFederationFilter.isValid() method can iterate over all validators and amke sure they are valid. Just a thought ! > Support pluggable validator for Header pre authentication provider > ------------------------------------------------------------------- > > Key: KNOX-861 > URL: https://issues.apache.org/jira/browse/KNOX-861 > Project: Apache Knox > Issue Type: Improvement > Components: Server > Reporter: Mohammad Kamrul Islam > Assignee: Mohammad Kamrul Islam > Fix For: 0.12.0 > > Attachments: KNOX-861.2.patch, KNOX-861.patch > > > Currently there are two validators : IPValidator, DefaultValidator, > IPValidator validates the source IP. DefaultValidator is basically a > no-auth. > The proposal is to provide a pluggable validator to support any custom > validation logic. Another requirement is to maintain the backward > compatibility of any existing features. -- This message was sent by Atlassian JIRA (v6.3.15#6346)