Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay merged PR #900: URL: https://github.com/apache/knox/pull/900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

pzampino commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1565979770 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/OAuthResource.java: ## @@ -71,7 +71,7 @@ public Response getAuthenticationToken() {

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

pzampino commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1565977800 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/OAuthResource.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564256326 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -780,26 +782,98 @@ private X509Certificate

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564253699 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/OAuthResource.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564253456 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -780,26 +782,98 @@ private X509Certificate

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564248082 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/OAuthResource.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564247287 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -780,26 +782,98 @@ private X509Certificate

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564244621 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -853,105 +917,148 @@ private Response getAuthenticationToken()

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564244148 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/OAuthResource.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564243026 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -626,14 +628,14 @@ public Response revoke(String token) {

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564241642 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -650,14 +652,14 @@ public Response revoke(String token) {

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564241397 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -650,14 +652,14 @@ public Response revoke(String token) {

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564239406 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -780,26 +782,98 @@ private X509Certificate

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564238609 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -184,7 +184,9 @@ public class TokenResource { private

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

lmccay commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1564238464 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/OAuthResource.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

Re: [PR] KNOX-3028 - add support for OAuth Token Exchange to KNOXTOKEN [knox]

pzampino commented on code in PR #900: URL: https://github.com/apache/knox/pull/900#discussion_r1563146549 ## gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java: ## @@ -853,105 +917,148 @@ private Response