[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=409987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409987 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 26/Mar/20 00:24 Start Date: 26/Mar/20 00:24 Worklog Time Spent: 10m Work Description: lmccay commented on pull request #301: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and … URL: https://github.com/apache/knox/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409987) Time Spent: 1h 10m (was: 1h) > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=409949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409949 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 25/Mar/20 22:58 Start Date: 25/Mar/20 22:58 Worklog Time Spent: 10m Work Description: lmccay commented on pull request #301: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and … URL: https://github.com/apache/knox/pull/301 …embedded commas Change-Id: I82e096d204accc0ba6a334b18d6287eb67adf74c (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull request? Embedded commas within a quoted string/col in CSV files result in separate cols currently. This patch allows for them to be ignored during the split() call via regex for identifying such patterns. It will result in the value - either header or cell value - as retaining the quotes currently. If this is not desired we can revisit and make configurable or just removed. ## How was this patch tested? New unit test added and existing unit tests ran. Manually tested against datasets with and without such quoted strings and embedded commas. Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409949) Time Spent: 1h (was: 50m) > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=409748=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409748 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 25/Mar/20 19:18 Start Date: 25/Mar/20 19:18 Worklog Time Spent: 10m Work Description: lmccay commented on pull request #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and … URL: https://github.com/apache/knox/pull/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409748) Time Spent: 50m (was: 40m) > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=407515=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407515 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 21/Mar/20 22:20 Start Date: 21/Mar/20 22:20 Worklog Time Spent: 10m Work Description: lmccay commented on issue #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and … URL: https://github.com/apache/knox/pull/299#issuecomment-602112910 Fixed to not rely on changes from PR #296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407515) Time Spent: 40m (was: 0.5h) > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=407504=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407504 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 21/Mar/20 19:35 Start Date: 21/Mar/20 19:35 Worklog Time Spent: 10m Work Description: lmccay commented on pull request #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and … URL: https://github.com/apache/knox/pull/299 …embedded commas Change-Id: I3d2e0dc8144e79c73df2067a7b6320e5d0a84266 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull request? Embedded commas within a quoted string/col in CSV files result in separate cols currently. This patch allows for them to be ignored during the split() call via regex for identifying such patterns. ## How was this patch tested? New unit test added and existing unit tests run. Manually tested with dataset with such embedded commas in quoted strings. Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407504) Time Spent: 0.5h (was: 20m) > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=407501=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407501 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 21/Mar/20 19:11 Start Date: 21/Mar/20 19:11 Worklog Time Spent: 10m Work Description: lmccay commented on pull request #298: KNOX-2307 URL: https://github.com/apache/knox/pull/298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407501) Time Spent: 20m (was: 10m) > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=407500=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407500 ] ASF GitHub Bot logged work on KNOX-2307: Author: ASF GitHub Bot Created on: 21/Mar/20 19:05 Start Date: 21/Mar/20 19:05 Worklog Time Spent: 10m Work Description: lmccay commented on pull request #298: KNOX-2307 URL: https://github.com/apache/knox/pull/298 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull request? Support for quoted strings with embedded commans within CSV files to be parsed into KnoxShellTable instance. ## How was this patch tested? Unit test added and existing unit tests ran. Manual testing with datasets that include such embedded commas and quoted string values. Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407500) Remaining Estimate: 0h Time Spent: 10m > CSVKnoxShellTableBuilder must support quoted strings and embedded commas > > > Key: KNOX-2307 > URL: https://issues.apache.org/jira/browse/KNOX-2307 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 1.4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Embedded commas within a quoted string/col in CSV files result in separate > cols currently. This patch allows for them to be ignored during the split() > call via regex for identifying such patterns. > It will result in the value - either header or cell value - as retaining the > quotes currently. If this is not desired we can revisit and make configurable > or just removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)