moresandeep commented on a change in pull request #355:
URL: https://github.com/apache/knox/pull/355#discussion_r447701443
##########
File path:
gateway-service-definitions/src/main/resources/services/druid-coordinator/0.0.1/service.xml
##########
@@ -22,6 +22,28 @@
<description>The Druid Coordinator process is primarily responsible
for segment management and distribution.
More specifically, the Druid Coordinator process communicates to
Historical processes to load or drop segments based on configurations.
The Druid Coordinator is responsible for loading new segments,
dropping outdated segments, managing segment replication, and balancing segment
load.</description>
+ <samples>
+ <sample>
+ <description>Fetch the current leader Coordinator of the
cluster</description>
Review comment:
Small case c in Coordinator.
##########
File path:
gateway-service-definitions/src/main/resources/services/ambari/2.2.0/service.xml
##########
@@ -20,6 +20,32 @@
<context>/ambari/api</context>
<shortDesc>Apache Ambari API</shortDesc>
<description>The Ambari API facilitates the management and monitoring
of the resources of an Apache Hadoop cluster.</description>
+ <samples>
+ <sample>
+ <description>Fetch all Ambari-mamanged cluaters</description>
Review comment:
Typo in cluster name
##########
File path:
gateway-service-definitions/src/main/resources/services/yarn-rm/2.5.0/service.xml
##########
@@ -21,6 +21,22 @@
<context>/resourcemanager</context>
<shortDesc>YARN Resource Manager</shortDesc>
<description>The YARN Resource Manager Service (RM) is the central
controlling authority for resource management and makes allocation decisions
ResourceManager has two main components: Scheduler and
ApplicationsManager.</description>
+ <samples>
+ <sample>
+ <description>Fecth cluster info</description>
Review comment:
Typo in Fetch
##########
File path: knox-homepage-ui/home/app/topologies/sample.ts
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export class Sample {
+ description: string;
+ value: string;
+}
Review comment:
Perhaps a newline?
##########
File path:
gateway-service-definitions/src/main/resources/services/zeppelinws/0.8.1/service.xml
##########
@@ -21,6 +21,27 @@
<context>/zeppelin/ws</context>
<shortDesc>Zeppelin WS API</shortDesc>
<description>Apache Zeppelin is a web-based notebook that enables
data-driven, interactive data analytics and collaborative documents with SQL,
Scala and more.</description>
+ <samples>
+ <sample>
+ <description>Fetch the available notes on your
server</description>
Review comment:
notebooks vs notes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
