[GitHub] [knox] pzampino commented on a diff in pull request #713: KNOX-2859 - Token Management UI improvements
pzampino commented on code in PR #713:
URL: https://github.com/apache/knox/pull/713#discussion_r1065889252
##
knox-token-management-ui/token-management/app/token.management.component.html:
##
@@ -20,90 +20,116 @@
+
My Knox Tokens
-
-
-
-Token ID
-Issued
-Expires
-Comment
-Additional Metadata
-Actions
-
-
-
-
-{{knoxToken.tokenId}}
-{{formatDateTime(knoxToken.issueTimeLong)}}
-{{formatDateTime(knoxToken.expirationLong)}}
-{{formatDateTime(knoxToken.expirationLong)}}
-{{knoxToken.metadata.comment}}
-
-
-
- {{metadata[0]}} = {{metadata[1]}}
-
-
-
-
+
+
+Search by Token ID, Comment or Metadata...
+
+
+
+
+
+Token ID
+{{knoxToken.tokenId}}
+
+
+
+Issued
+{{formatDateTime(knoxToken.issueTimeLong)}}
+
+
+
+Expires
+{{formatDateTime(knoxToken.expirationLong)}}
+
+
+
+Comment
+{{knoxToken.metadata.comment}}
+
+
+
+Additional
Metadata
+
+
+
+ {{metadata[0]}} = {{metadata[1]}}
+
+
+
+
+
+
+Actions
+
Disable
Enable
Revoke
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
-
-Impersonation Knox Tokens
-
-
-
-Token ID
-Issued
-Expires
-Comment
-Additional Metadata
-Impersonated User
-
-
-
-
-{{doAsKnoxtoken.tokenId}}
-{{formatDateTime(doAsKnoxtoken.issueTimeLong)}}
-{{formatDateTime(doAsKnoxtoken.expirationLong)}}
-{{formatDateTime(doAsKnoxtoken.expirationLong)}}
-{{doAsKnoxtoken.metadata.comment}}
-
-
-
- {{metadata[0]}} = {{metadata[1]}}
-
-
-
-{{doAsKnoxtoken.metadata.userName}}
-
-
-
-
-
-
-
-
-
-
+
Review Comment:
I recognize that this is not directly related to this PR.
I think my confusion may be due to the inability to disable/revoke the
tokens in the second table, but that is a separate topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [knox] pzampino commented on a diff in pull request #713: KNOX-2859 - Token Management UI improvements
pzampino commented on code in PR #713:
URL: https://github.com/apache/knox/pull/713#discussion_r1064780286
##
knox-token-management-ui/token-management/app/token.management.component.ts:
##
@@ -57,13 +117,29 @@ export class TokenManagementComponent implements OnInit {
}
fetchAllKnoxTokens(): void {
-this.fetchKnoxTokens(true);
this.fetchKnoxTokens(false);
+this.fetchKnoxTokens(true);
Review Comment:
Is the order important here? Just trying to understand the change.
##
knox-token-management-ui/token-management/app/token.management.component.html:
##
@@ -20,90 +20,116 @@
+
My Knox Tokens
-
-
-
-Token ID
-Issued
-Expires
-Comment
-Additional Metadata
-Actions
-
-
-
-
-{{knoxToken.tokenId}}
-{{formatDateTime(knoxToken.issueTimeLong)}}
-{{formatDateTime(knoxToken.expirationLong)}}
-{{formatDateTime(knoxToken.expirationLong)}}
-{{knoxToken.metadata.comment}}
-
-
-
- {{metadata[0]}} = {{metadata[1]}}
-
-
-
-
+
+
+Search by Token ID, Comment or Metadata...
+
+
+
+
+
+Token ID
+{{knoxToken.tokenId}}
+
+
+
+Issued
+{{formatDateTime(knoxToken.issueTimeLong)}}
+
+
+
+Expires
+{{formatDateTime(knoxToken.expirationLong)}}
+
+
+
+Comment
+{{knoxToken.metadata.comment}}
+
+
+
+Additional
Metadata
+
+
+
+ {{metadata[0]}} = {{metadata[1]}}
+
+
+
+
+
+
+Actions
+
Disable
Enable
Revoke
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
-
-Impersonation Knox Tokens
-
-
-
-Token ID
-Issued
-Expires
-Comment
-Additional Metadata
-Impersonated User
-
-
-
-
-{{doAsKnoxtoken.tokenId}}
-{{formatDateTime(doAsKnoxtoken.issueTimeLong)}}
-{{formatDateTime(doAsKnoxtoken.expirationLong)}}
-{{formatDateTime(doAsKnoxtoken.expirationLong)}}
-{{doAsKnoxtoken.metadata.comment}}
-
-
-
- {{metadata[0]}} = {{metadata[1]}}
-
-
-
-{{doAsKnoxtoken.metadata.userName}}
-
-
-
-
-
-
-
-
-
-
+
Review Comment:
Why are tokens acquired with impersonation presented in a distinct table
from "normal" tokens? Couldn't it be a single table? The relationship between
the tables isn't entirely clear to me, and you can only act on rows in the My
Knox Tokens table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
