[GitHub] [knox] smolnar82 commented on a diff in pull request #716: KNOX-2748 - Fixed HashiCorp alias service getPasswordFromAliasForCluster

2023-01-19 Thread GitBox 


smolnar82 commented on code in PR #716:
URL: https://github.com/apache/knox/pull/716#discussion_r1081102335


##
gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java:
##
@@ -184,6 +185,9 @@ public void testVaultIntegration() throws Exception {
 assertNull(aliasService.getPasswordFromAliasForCluster(clusterName, 
alias));
 assertEquals(0, aliasService.getAliasesForCluster(clusterName).size());
 
+char[] generatedPassword = 
aliasService.getPasswordFromAliasForCluster(clusterName, alias, true);
+assertNotNull(generatedPassword != null);
+

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [knox] smolnar82 commented on a diff in pull request #716: KNOX-2748 - Fixed HashiCorp alias service getPasswordFromAliasForCluster

2023-01-19 Thread GitBox 


smolnar82 commented on code in PR #716:
URL: https://github.com/apache/knox/pull/716#discussion_r1080967212


##
gateway-service-hashicorp-vault/src/test/java/org/apache/knox/gateway/backend/hashicorp/vault/TestHashicorpVaultAliasService.java:
##
@@ -184,6 +185,9 @@ public void testVaultIntegration() throws Exception {
 assertNull(aliasService.getPasswordFromAliasForCluster(clusterName, 
alias));
 assertEquals(0, aliasService.getAliasesForCluster(clusterName).size());
 
+char[] generatedPassword = 
aliasService.getPasswordFromAliasForCluster(clusterName, alias, true);
+assertNotNull(generatedPassword != null);
+

Review Comment:
   You may want to make sure the generated password for `alias` is not the same 
as `aliasPassword`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org