Re: Proposal: Gradle as the primary build tool

I am also in favor of this switch. I have nothing to add that you're not already aware of (i.e. need to implement some sort of failed test retry to make the pre-commit change). On Fri, Apr 27, 2018 at 10:05 AM, Grant Henke wrote: > A recent patch has evaluated and addressed any remaining Artifact

Re: Enabled error-prone on Java builds

> I think a nice half-way point would be for the "tidy" precommit build to > run Gradle (and spotbugs and any other static analysis) and propagate the > warnings as comments on the gerrit review. This is a bit more easy to > handle than an outright build failure for the developer but should still >

Re: Enabled error-prone on Java builds

On Fri, Apr 27, 2018 at 11:50 AM, Adar Lieber-Dembo wrote: > > Currently I've set up error-prone to only generate warnings and not fail > > the build even for errors it considers to be serious. So, even if you > don't > > configure your IDE specially, you shouldn't see any new failures on > gerri

Re: Enabled error-prone on Java builds

> Currently I've set up error-prone to only generate warnings and not fail > the build even for errors it considers to be serious. So, even if you don't > configure your IDE specially, you shouldn't see any new failures on gerrit, > etc, due to these warnings. But, please let's all try to keep it "

Enabled error-prone on Java builds

Hey folks, Adar suggested I give a heads up to a wider audience in case people missed the code reviews this past week. So... heads up: Earlier this week we committed c55ddd9bc85094c5f780427c3fc82b2219015d24 which switches the Java compiler as used by Gradle from the normal javac to 'error-prone'.

Re: Proposal: Gradle as the primary build tool

A recent patch has evaluated and addressed any remaining Artifact issues. See the commit message here for details: https://github.com/apache/kudu/commit/7f04873975d73bb335e09ee2a99fd4b0cd89 That effort improved both the Maven and the Gradle artifacts. I wouldn't say the two are exactly the sa

Re: Proposal: Gradle as the primary build tool

I'm on board with this. Have we already tested the artifact publishing process with gradle? Does the resulting pom look identical to the pom that we publish with maven? I assume so, but want to make sure we don't miss this part of the process which we don't do except for at release time. -Todd O

Proposal: Gradle as the primary build tool

Hi Kudu dev community, For some time now the Java build has had an experimental Gradle build ( KUDU-2066 ) along side the primary Maven build. Since then the Gradle build has been improved to support all of the necessary functionality of the Maven b

Re: Kudu 1.7.1 Release

Good idea. I have cherry picked those patches via Gerrit and added you as a reviewer. Thank you, Grant On Thu, Apr 26, 2018 at 5:16 PM, Adar Lieber-Dembo wrote: > Thanks for volunteering, Grant. > > Here are a couple of other patches to consider. None of them will > affect production use cases