shaofengshi commented on a change in pull request #286: KYLIN-3617 Use job's
cache in job scheduler
URL: https://github.com/apache/kylin/pull/286#discussion_r224976002
##########
File path: core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
##########
@@ -391,4 +405,13 @@ public void deleteJobOutput(String uuid) throws
PersistentException {
throw new PersistentException(e);
}
}
+
+ public void reloadAll() throws IOException {
+ try (AutoReadWriteLock.AutoLock lock =
executableDigestMapLock.lockForWrite()) {
+ executableDigestCrud.reloadAll();
Review comment:
Why this is in "lockForWrite()" but the next reload is in "lockForRead"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
