-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64063/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3060
https://issues.apache.org/jira/browse/KYLIN-3060
Repository: kylin
Description
-------
When you set the invalid parameter for creating or updating a streaming table,
the client will show an error message dialog.
I analyze the Kylin server log, there are some null pointer exceptions, then I
analyze the StreamingController.java, whose logical processing of streaming
table has a bug, which will cause a NullPointerException.
So I have repaired it, then the client will tell you the detail error message,
the server no longer throws an null point exception.
you can check the patch, thanks!
Kylin server log
2017-11-24 18:42:21,531 ERROR [http-bio-7070-exec-10]
controller.StreamingController:202 : Failed to deal with the request:null
java.lang.NullPointerException
at
org.apache.kylin.source.kafka.KafkaConfigManager.updateKafkaConfig(KafkaConfigManager.java:156)
at
org.apache.kylin.rest.service.KafkaConfigService.updateKafkaConfig(KafkaConfigService.java:84)
at
org.apache.kylin.rest.controller.StreamingController.updateStreamingConfig(StreamingController.java:198)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
Diffs
-----
server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java
593abea
Diff: https://reviews.apache.org/r/64063/diff/1/
Testing
-------
Thanks,
pengjianhua
