[GitHub] shaofengshi closed pull request #242: KYLIN-3575, fix unclosed JDBC connection in DriverTest.
shaofengshi closed pull request #242: KYLIN-3575, fix unclosed JDBC connection
in DriverTest.
URL: https://github.com/apache/kylin/pull/242
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
b/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
index 11dbcde45d..1ffec6d132 100644
--- a/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
+++ b/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
@@ -221,6 +221,7 @@ public void testSSLFromURL() throws SQLException {
assertEquals("test_url", ((KylinConnection) conn).getBaseUrl());
assertEquals("test_db", ((KylinConnection) conn).getProject());
assertTrue(Boolean.parseBoolean((String) ((KylinConnection)
conn).getConnectionProperties().get("ssl")));
+conn.close();
}
@Test
@@ -245,6 +246,8 @@ public void testCalciteProps() throws SQLException {
assertEquals("false",
connProps2.getProperty("kylin.query.calcite.extras-props.caseSensitive"));
assertEquals("UNCHANGED",
connProps2.getProperty("kylin.query.calcite.extras-props.unquotedCasing"));
assertEquals("BACK_TICK",
connProps2.getProperty("kylin.query.calcite.extras-props.quoting"));
+conn.close();
+conn2.close();
}
private void printResultSet(ResultSet rs) throws SQLException {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: Kylin-Master-JDK-1.8 failures
Hi Daniel, thank you for fixing it and updating us. We will take care of it. Daniel Pono Takamori 于2018年9月24日周一 上午6:23写道： > Hey Kylin folks, > When clearing disk space on H26 I found that your job was pinned to it > (I've since moved the label for the job to the generic 'ubuntu' > label). The job failed about 20 times today and it's because of a > corrupted .git folder which appeared to just be filling and ended up > huge: `97G Kylin-Master-JDK-1.8/.git/objects/pack` > I've purged the repo and set your job to 'Delete workspace before > build starts' and now > https://builds.apache.org/job/Kylin-Master-JDK-1.8/2317/ finished > successfully. > Keep an eye on those failures, I only spotted them 'cuz of cleaning H26. > > Cheers, > -Pono > -- Best regards, Shaofeng Shi 史少锋
Re: [Announce] Apache Kylin 2.5.0 released
Adding a blog post to introduce this release, we encourage you to upgrade and provide feedback in the mailing list: English: https://kylin.apache.org/blog/2018/09/20/release-v2.5.0/ Chinese: https://kylin.apache.org/cn/blog/2018/09/20/release-v2.5.0/ Thanks! Billy Liu 于2018年9月19日周三 下午9:23写道： > Thanks Shaofeng. > > I think this is one of the most remarkable releases since 2.0. > A few highlights: > [KYLIN-3521] - Enable Cube Planner by default > [KYLIN-2565] - Support Hadoop 3.0 > [KYLIN-3033] - Support HBase 2.0 > [KYLIN-3418] - User interface for hybrid model > [KYLIN-3427] - Convert to HFile in Spark > [KYLIN-3441] - Merge cube segments in Spark > [KYLIN-3442] - Fact distinct columns in Spark > [KYLIN-3453] - Improve cube size estimation for TOPN, COUNT DISTINCT > and a lot of bug fixes and improvement on stability. > > With Warm regards > > Billy Liu > ShaoFeng Shi 于2018年9月19日周三 上午8:31写道： > > > > The Apache Kylin team is pleased to announce the immediate availability > of the 2.5.0 release. > > > > This is a major release after 2.4, with more than 100 enhancements and > bug fixes. All of the changes in this release can be found in: > > https://kylin.apache.org/docs/release_notes.html > > > > You can download the source release and binary packages from Apache > Kylin's download page: https://kylin.apache.org/download/ > > > > Apache Kylin is an open source Distributed Analytics Engine designed to > provide SQL interface and multi-dimensional analysis (OLAP) on Apache > Hadoop, supporting extremely large datasets. > > > > Apache Kylin lets you query massive dataset at sub-second latency in 3 > steps: > > 1. Identify a star schema or snowflake schema data set on Hadoop. > > 2. Build Cube on Hadoop. > > 3. Query data with ANSI-SQL and get results in sub-second, via ODBC, > JDBC or RESTful API. > > > > Thanks to everyone who has contributed to the 2.5.0 release. > > > > We welcome your help and feedback. For more information on how to > > report problems, and to get involved, visit the project website at > > https://kylin.apache.org/ > > > > -- > > Best regards, > > > > Shaofeng Shi 史少锋 > > > -- Best regards, Shaofeng Shi 史少锋
[GitHub] asfgit commented on issue #243: Update to execute the beeline to find CLASSPATH
asfgit commented on issue #243: Update to execute the beeline to find CLASSPATH URL: https://github.com/apache/kylin/pull/243#issuecomment-423965743 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #243: Update to execute the beeline to find CLASSPATH
asfgit commented on issue #243: Update to execute the beeline to find CLASSPATH URL: https://github.com/apache/kylin/pull/243#issuecomment-423965744 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rtjarvis opened a new pull request #243: Update to execute the beeline to find CLASSPATH
rtjarvis opened a new pull request #243: Update to execute the beeline to find CLASSPATH URL: https://github.com/apache/kylin/pull/243 The beeline "set" hangs because there is no terminating ; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
regrading model construction apache kylin
what's the need of lookup table in creation of model in apache kylin. If there is onle one table do we need lookup table even then? Thank you. regrads Vishnu Vardhan G Software Intern Orzota
[GitHub] shaofengshi closed pull request #241: KYLIN-3546 Add column which belongs to root fact table in join relation but lost
shaofengshi closed pull request #241: KYLIN-3546 Add column which belongs to
root fact table in join relation but lost
URL: https://github.com/apache/kylin/pull/241
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaInputBase.java
b/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaInputBase.java
index a624f8fbb8..cb2e14ce5c 100644
---
a/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaInputBase.java
+++
b/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaInputBase.java
@@ -18,8 +18,11 @@
package org.apache.kylin.source.kafka;
+import java.util.LinkedList;
import java.util.List;
+import java.util.Set;
+import com.google.common.collect.Sets;
import org.apache.kylin.cube.CubeSegment;
import org.apache.kylin.cube.model.CubeDesc;
import org.apache.kylin.engine.mr.JobBuilderSupport;
@@ -32,7 +35,10 @@
import org.apache.kylin.metadata.model.DataModelDesc;
import org.apache.kylin.metadata.model.IJoinedFlatTableDesc;
import org.apache.kylin.metadata.model.ISegment;
+import org.apache.kylin.metadata.model.JoinDesc;
+import org.apache.kylin.metadata.model.JoinTableDesc;
import org.apache.kylin.metadata.model.SegmentRange;
+import org.apache.kylin.metadata.model.TableRef;
import org.apache.kylin.metadata.model.TblColRef;
import org.apache.kylin.source.hive.CreateFlatHiveTableStep;
import org.apache.kylin.source.hive.GarbageCollectionStep;
@@ -89,7 +95,23 @@ public DataModelDesc getDataModel() {
@Override
public List getAllColumns() {
-return flatDesc.getFactColumns();
+final Set factTableColumnSet = Sets.newHashSet();
+TableRef rootFactTable = getDataModel().getRootFactTable();
+for (TblColRef colRef : flatDesc.getAllColumns()) {
+if (colRef.getTableRef().equals(rootFactTable)) {
+factTableColumnSet.add(colRef);
+}
+}
+// Add column which belongs to root fact table in join
relation but lost
+for (JoinTableDesc joinTableDesc :
getDataModel().getJoinTables()) {
+JoinDesc join = joinTableDesc.getJoin();
+for (TblColRef colRef : join.getForeignKeyColumns()) {
+if (colRef.getTableRef().equals(rootFactTable)) {
+factTableColumnSet.add(colRef);
+}
+}
+}
+return new LinkedList<>(factTableColumnSet);
}
@Override
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (KYLIN-3587) Null value is used in IllegalStateException message
Ted Yu created KYLIN-3587:
-
Summary: Null value is used in IllegalStateException message
Key: KYLIN-3587
URL: https://issues.apache.org/jira/browse/KYLIN-3587
Project: Kylin
Issue Type: Bug
Reporter: Ted Yu
In ProjectManager :
{code}
TableDesc table = metaMgr.getTableDesc(tableId, projectName);
if (table == null) {
throw new IllegalStateException("Cannot find table '" +
table + "' in metadata manager");
{code}
Since table is null, the exception message is not helpful.
It seems including tableId in the message is better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] asfgit commented on issue #244: KYLIN-3582 String compare should use equals method
asfgit commented on issue #244: KYLIN-3582 String compare should use equals method URL: https://github.com/apache/kylin/pull/244#issuecomment-424014579 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hit-lacus opened a new pull request #244: KYLIN-3582 String compare should use equals method
hit-lacus opened a new pull request #244: KYLIN-3582 String compare should use equals method URL: https://github.com/apache/kylin/pull/244 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #244: KYLIN-3582 String compare should use equals method
asfgit commented on issue #244: KYLIN-3582 String compare should use equals method URL: https://github.com/apache/kylin/pull/244#issuecomment-424014580 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (KYLIN-3588) Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
Ted Yu created KYLIN-3588:
-
Summary: Potentially duplicate put to
RemoveBlackoutRealizationsRule#filters map
Key: KYLIN-3588
URL: https://issues.apache.org/jira/browse/KYLIN-3588
Project: Kylin
Issue Type: Bug
Reporter: Ted Yu
Here is related code:
{code}
IRealizationFilter filter = filters.get(conf);
if (filter == null) {
try {
Class clz =
ClassUtil.forName(conf.getQueryRealizationFilter(), IRealizationFilter.class);
filter =
clz.getConstructor(KylinConfig.class).newInstance(conf);
} catch (Exception e) {
throw new RuntimeException(e);
}
filters.put(conf, filter);
{code}
Two threads may find out there is no filter for conf, they would proceed with
creation of IRealizationFilter instances and try to put into the map.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (KYLIN-3589) Different type is used to check presence in Collection in AclPermissionUtil
Ted Yu created KYLIN-3589:
-
Summary: Different type is used to check presence in Collection in
AclPermissionUtil
Key: KYLIN-3589
URL: https://issues.apache.org/jira/browse/KYLIN-3589
Project: Kylin
Issue Type: Bug
Reporter: Ted Yu
Here is related code:
{code}
public static List transformAuthorities(Collection authorities) {
List ret = new ArrayList();
for (GrantedAuthority auth : authorities) {
if (!authorities.contains(auth.getAuthority())) {
{code}
auth.getAuthority() shouldn't be used to check presence in the Collection since
it is not of GrantedAuthority type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (KYLIN-3590) Missing argument to exception message String in ModelController
Ted Yu created KYLIN-3590:
-
Summary: Missing argument to exception message String in
ModelController
Key: KYLIN-3590
URL: https://issues.apache.org/jira/browse/KYLIN-3590
Project: Kylin
Issue Type: Bug
Reporter: Ted Yu
Here is related code:
{code}
String.format(Locale.ROOT,
"Invalid model name %s, only letters, numbers and
underscore " + "supported."),
{code}
There is no argument for '%s'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] shaofengshi closed pull request #244: KYLIN-3582 String compare should use equals method
shaofengshi closed pull request #244: KYLIN-3582 String compare should use
equals method
URL: https://github.com/apache/kylin/pull/244
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
b/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
index 894386ee9b..6452d78242 100644
---
a/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
+++
b/core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java
@@ -262,11 +262,10 @@ public String toString() {
public RecordReserveKeyEnum getByKey(String key) {
for (RecordReserveKeyEnum reserveKey :
RecordReserveKeyEnum.values()) {
-if (reserveKey.reserveKey == key) {
+if (reserveKey.reserveKey.equals(key)) {
return reserveKey;
}
}
-
return null;
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] shaofengshi commented on issue #243: Update to execute the beeline to find CLASSPATH
shaofengshi commented on issue #243: Update to execute the beeline to find CLASSPATH URL: https://github.com/apache/kylin/pull/243#issuecomment-424167617 Hello rtjarvis, could you please create a JIRA with the issue description, and then associate the commit with a message "KYLIN- description blabla", just like the other PRs? That would facilitate the issue management. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] caolijun1166 opened a new pull request #245: KYLIN-3586
caolijun1166 opened a new pull request #245: KYLIN-3586 URL: https://github.com/apache/kylin/pull/245 Solve KYLIN-3586: Use parseInt() to parse a primitive instead of to use boxing/unboxing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #245: KYLIN-3586
asfgit commented on issue #245: KYLIN-3586 URL: https://github.com/apache/kylin/pull/245#issuecomment-424172929 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #245: KYLIN-3586
asfgit commented on issue #245: KYLIN-3586 URL: https://github.com/apache/kylin/pull/245#issuecomment-424172928 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #247: Fix travis ci
asfgit commented on issue #247: Fix travis ci URL: https://github.com/apache/kylin/pull/247#issuecomment-42418 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #247: Fix travis ci
asfgit commented on issue #247: Fix travis ci URL: https://github.com/apache/kylin/pull/247#issuecomment-424189998 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi opened a new pull request #247: Fix travis ci
shaofengshi opened a new pull request #247: Fix travis ci URL: https://github.com/apache/kylin/pull/247 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #247: Fix travis ci
shaofengshi closed pull request #247: Fix travis ci
URL: https://github.com/apache/kylin/pull/247
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server-base/src/main/java/org/apache/kylin/rest/controller/JobController.java
b/server-base/src/main/java/org/apache/kylin/rest/controller/JobController.java
index efe9e0ebda..f79281bb7f 100644
---
a/server-base/src/main/java/org/apache/kylin/rest/controller/JobController.java
+++
b/server-base/src/main/java/org/apache/kylin/rest/controller/JobController.java
@@ -78,7 +78,7 @@
try {
jobSearchMode =
JobService.JobSearchMode.valueOf(jobRequest.getJobSearchMode());
} catch (IllegalArgumentException e) {
-logger.error("Invalid value for JobSearchMode: '" +
jobRequest.getJobSearchMode() + "', skip it.", e);
+logger.warn("Invalid value for JobSearchMode: '" +
jobRequest.getJobSearchMode() + "', skip it.");
}
}
diff --git
a/server/src/test/java/org/apache/kylin/rest/controller/JobControllerTest.java
b/server/src/test/java/org/apache/kylin/rest/controller/JobControllerTest.java
index 439381efa3..ac2c904af7 100644
---
a/server/src/test/java/org/apache/kylin/rest/controller/JobControllerTest.java
+++
b/server/src/test/java/org/apache/kylin/rest/controller/JobControllerTest.java
@@ -122,16 +122,4 @@ public void testBasics() throws IOException,
PersistentException {
}
}
-@Test(expected = RuntimeException.class)
-public void testResume() throws IOException {
-JobBuildRequest jobBuildRequest = new JobBuildRequest();
-jobBuildRequest.setBuildType("BUILD");
-jobBuildRequest.setStartTime(2013033108L);
-jobBuildRequest.setEndTime(2013121208L);
-
-// Yang: how to rebuild a cube does not exists?!
-JobInstance job = cubeController.rebuild(CUBE_NAME, jobBuildRequest);
-
-jobSchedulerController.resume(job.getId());
-}
}
diff --git
a/server/src/test/java/org/apache/kylin/rest/security/KylinUserManagerTest.java
b/server/src/test/java/org/apache/kylin/rest/security/KylinUserManagerTest.java
index 7024c4f0e2..e83f21d6db 100644
---
a/server/src/test/java/org/apache/kylin/rest/security/KylinUserManagerTest.java
+++
b/server/src/test/java/org/apache/kylin/rest/security/KylinUserManagerTest.java
@@ -36,15 +36,15 @@ public void testBasic() throws IOException,
InterruptedException {
final KylinUserManager managerB = new KylinUserManager(configB);
ManagedUser u1 = new ManagedUser("u1", "skippped", false,
Lists. newArrayList());
managerA.update(u1);
-Thread.sleep(1000);
+Thread.sleep(3000);
ManagedUser u11 = new ManagedUser("u1", "password", false,
Lists. newArrayList(new
SimpleGrantedAuthority(Constant.ROLE_ANALYST)));
managerB.update(u11);
-Thread.sleep(1000);
+Thread.sleep(3000);
Assert.assertEquals("password", managerA.get("u1").getPassword());
Assert.assertEquals("password", managerB.get("u1").getPassword());
managerB.delete("u1");
-Thread.sleep(1000);
+Thread.sleep(3000);
Assert.assertNull(managerA.get("u1"));
Assert.assertNull(managerB.get("u1"));
}
diff --git
a/server/src/test/java/org/apache/kylin/rest/security/TableACLManagerTest.java
b/server/src/test/java/org/apache/kylin/rest/security/TableACLManagerTest.java
index 6076a10462..3309a6d6a9 100644
---
a/server/src/test/java/org/apache/kylin/rest/security/TableACLManagerTest.java
+++
b/server/src/test/java/org/apache/kylin/rest/security/TableACLManagerTest.java
@@ -46,12 +46,12 @@ public void test() throws Exception {
Assert.assertEquals(0,
tableACLManagerB.getTableACLByCache(PROJECT).size());
tableACLManagerA.addTableACL(PROJECT, USER, TABLE,
MetadataConstants.TYPE_USER);
// if don't sleep, manager B's get method is faster than notify
-Thread.sleep(1000);
+Thread.sleep(3000);
Assert.assertEquals(1,
tableACLManagerB.getTableACLByCache(PROJECT).size());
Assert.assertEquals(1,
tableACLManagerA.getTableACLByCache(PROJECT).size());
tableACLManagerB.deleteTableACL(PROJECT, USER, TABLE,
MetadataConstants.TYPE_USER);
-Thread.sleep(1000);
+Thread.sleep(3000);
Assert.assertEquals(0,
tableACLManagerA.getTableACLByCache(PROJECT).size());
}
}
diff --git
a/server/src/test/java/org/apache/kylin/rest/util/MultiNodeManagerTestBase.java
b/server/src/test/java/org/apache/kylin/rest/util/MultiNodeManagerTestBase.java
index 9610f2f277..bbee7bd96e 100644
---
a/server/src/test/java/org/apache/kylin/rest/util/MultiNodeManagerTestBase.java
+++
[GitHub] codecov-io commented on issue #247: Fix travis ci
codecov-io commented on issue #247: Fix travis ci URL: https://github.com/apache/kylin/pull/247#issuecomment-424193243 # [Codecov](https://codecov.io/gh/apache/kylin/pull/247?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d8c2a28`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/247?src=pr=tree) ```diff @@Coverage Diff@@ ## master #247 +/- ## = Coverage ? 21.11% Complexity? 4405 = Files ? 1087 Lines ?69878 Branches ?10103 = Hits ?14757 Misses?53722 Partials ? 1399 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/247?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/kylin/rest/controller/JobController.java](https://codecov.io/gh/apache/kylin/pull/247/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9Kb2JDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/247?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/247?src=pr=footer). Last update [d8c2a28...523c24e](https://codecov.io/gh/apache/kylin/pull/247?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #247: Fix travis ci
codecov-io edited a comment on issue #247: Fix travis ci URL: https://github.com/apache/kylin/pull/247#issuecomment-424193243 # [Codecov](https://codecov.io/gh/apache/kylin/pull/247?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d8c2a28`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/247?src=pr=tree) ```diff @@Coverage Diff@@ ## master #247 +/- ## = Coverage ? 21.11% Complexity? 4405 = Files ? 1087 Lines ?69878 Branches ?10103 = Hits ?14757 Misses?53722 Partials ? 1399 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/247?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/kylin/rest/controller/JobController.java](https://codecov.io/gh/apache/kylin/pull/247/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9Kb2JDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/247?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/247?src=pr=footer). Last update [d8c2a28...5b7d439](https://codecov.io/gh/apache/kylin/pull/247?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #246: KYLIN-3574 Close underlying resource of lookup table
asfgit commented on issue #246: KYLIN-3574 Close underlying resource of lookup table URL: https://github.com/apache/kylin/pull/246#issuecomment-424175244 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #246: KYLIN-3574 Close underlying resource of lookup table
asfgit commented on issue #246: KYLIN-3574 Close underlying resource of lookup table URL: https://github.com/apache/kylin/pull/246#issuecomment-424175245 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hit-lacus opened a new pull request #246: KYLIN-3574 Close underlying resource of lookup table
hit-lacus opened a new pull request #246: KYLIN-3574 Close underlying resource of lookup table URL: https://github.com/apache/kylin/pull/246 HTable should be closed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
