Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

> On Dec. 11, 2015, 9:53 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java, > > lines 46-53 > > > > > > Nothing big, but the class can

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052647#comment-15052647 ] Rajat Khandelwal commented on LENS-885: --- Seems I missed one checkstyle error. Updating now. >

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052645#comment-15052645 ] Rajat Khandelwal commented on LENS-885: --- Seems I missed one checkstyle error. Updating now. >

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

> On Dec. 11, 2015, noon, Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 203 > > > > > > did not understand why we are changing `extractPruneCause` to

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/ --- (Updated Dec. 11, 2015, 4:34 p.m.) Review request for lens. Bugs: LENS-851

[jira] [Updated] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-885: - Fix Version/s: 2.5 Status: Open (was: Patch Available) [~prongs], seems

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109943 ---

[jira] [Updated] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-885: -- Attachment: LENS-885.04.patch > Cleanup of Cube test cases > -- > >

[jira] [Updated] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-885: -- Status: Patch Available (was: In Progress) > Cleanup of Cube test cases >

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052649#comment-15052649 ] Rajat Khandelwal commented on LENS-885: --- Taking patch from reviewboard and attaching > Cleanup of

[jira] [Updated] (LENS-270) The exception thrown for no candidate fact should contain only brief error

[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-270: Attachment: LENS-270_2.patch > The exception thrown for no candidate fact should contain only brief

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052674#comment-15052674 ] Rajat Khandelwal commented on LENS-851: --- Taking patch from reviewboard and attaching > queries where

[jira] [Work started] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-885 started by Rajat Khandelwal. - > Cleanup of Cube test cases > -- > >

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40739/ --- (Updated Dec. 11, 2015, 5:01 p.m.) Review request for lens. Bugs: LENS-885

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052625#comment-15052625 ] Hadoop QA commented on LENS-885: Applied patch:

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/ --- (Updated Dec. 11, 2015, 9:44 a.m.) Review request for lens. Changes ---

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

> On Dec. 11, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java, > > line 48 > > > > > > Can you add comments about what

[jira] [Updated] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-851: -- Status: Patch Available (was: In Progress) > queries where results of two storage tables of same

[jira] [Updated] (LENS-890) Allow per-queue driver max launched queries constraints

[ https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-890: -- Status: Patch Available (was: In Progress) > Allow per-queue driver max launched queries

[jira] [Updated] (LENS-890) Allow per-queue driver max launched queries constraints

[ https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-890: -- Attachment: LENS-890.03.patch > Allow per-queue driver max launched queries constraints >

[jira] [Commented] (LENS-890) Allow per-queue driver max launched queries constraints

[ https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052749#comment-15052749 ] Rajat Khandelwal commented on LENS-890: --- Taking patch from reviewboard and attaching > Allow

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052813#comment-15052813 ] Hadoop QA commented on LENS-851: Applied patch:

[jira] [Commented] (LENS-890) Allow per-queue driver max launched queries constraints

[ https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052824#comment-15052824 ] Hadoop QA commented on LENS-890: Applied patch:

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/#review109959 --- Ship it! Please update testing done with latest patch. -

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39911/ --- (Updated Dec. 11, 2015, 12:55 p.m.) Review request for lens. Changes ---

[jira] [Updated] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-851: -- Attachment: LENS-851.local.patch > queries where results of two storage tables of same fact are

[jira] [Updated] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-851: -- Attachment: LENS-851.local.1.patch > queries where results of two storage tables of same fact are

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review109958 ---

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052709#comment-15052709 ] Hadoop QA commented on LENS-885: Applied patch:

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052780#comment-15052780 ] Hadoop QA commented on LENS-270: Applied patch:

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052741#comment-15052741 ] Hadoop QA commented on LENS-851: Applied patch:

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/ --- (Updated Dec. 11, 2015, 7:02 p.m.) Review request for lens. Bugs: LENS-890

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[ https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052821#comment-15052821 ] Hudson commented on LENS-885: - UNSTABLE: Integrated in Lens-Commit #1150 (See

[jira] [Updated] (LENS-760) Session close should not result in running query failures.

[ https://issues.apache.org/jira/browse/LENS-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Barr updated LENS-760: - Attachment: LENS-760.7.patch > Session close should not result in running query failures. >

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

> On Dec. 11, 2015, noon, Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, > > line 93 > > > > > > Instead of repeated casting by callers, extractPruneCause

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

[ https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053083#comment-15053083 ] Hadoop QA commented on LENS-270: Patch does not apply. Build job:

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

> On Dec. 11, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 1295 > > > > > > Should we not persist opHandleToSessionHandle

[jira] [Commented] (LENS-760) Session close should not result in running query failures.

[ https://issues.apache.org/jira/browse/LENS-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053504#comment-15053504 ] Hudson commented on LENS-760: - SUCCESS: Integrated in Lens-Commit-Java8 #66 (See

[jira] [Commented] (LENS-760) Session close should not result in running query failures.

[ https://issues.apache.org/jira/browse/LENS-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053525#comment-15053525 ] Hudson commented on LENS-760: - UNSTABLE: Integrated in Lens-Commit #1151 (See

[jira] [Commented] (LENS-760) Session close should not result in running query failures.

[ https://issues.apache.org/jira/browse/LENS-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053161#comment-15053161 ] Hadoop QA commented on LENS-760: Applied patch:

[jira] [Commented] (LENS-760) Session close should not result in running query failures.

[ https://issues.apache.org/jira/browse/LENS-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053199#comment-15053199 ] Deepak Barr commented on LENS-760: -- Committed. > Session close should not result in running query

[jira] [Updated] (LENS-760) Session close should not result in running query failures.

[ https://issues.apache.org/jira/browse/LENS-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Barr updated LENS-760: - Resolution: Fixed Status: Resolved (was: Patch Available) > Session close should not result in

[jira] [Commented] (LENS-743) Query failure retries for transient errors

[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052402#comment-15052402 ] Rajat Khandelwal commented on LENS-743: --- I'm thinking Lens server will consult the driver regarding