Re: Review Request 48719: LENS-1186: Refactor exception handling in QueryServiceResource

2016-06-15 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48719/#review137922 --- Ship it! Ship It! - Amareshwari Sriramadasu On June 15,

[jira] [Commented] (LENS-1188) Cap timeout time in execute_with_timeout option

2016-06-15 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331489#comment-15331489 ] Puneet Gupta commented on LENS-1188: Thinking of capping at 1 minute by default . We can set different

[jira] [Created] (LENS-1188) Cap timeout time in execute_with_timeout option

2016-06-15 Thread Puneet Gupta (JIRA)
Puneet Gupta created LENS-1188: -- Summary: Cap timeout time in execute_with_timeout option Key: LENS-1188 URL: https://issues.apache.org/jira/browse/LENS-1188 Project: Apache Lens Issue Type:

[jira] [Work started] (LENS-1186) Refactor exception handling in QueryServiceResource

2016-06-15 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1186 started by Rajat Khandelwal. -- > Refactor exception handling in QueryServiceResource >

[jira] [Commented] (LENS-1186) Refactor exception handling in QueryServiceResource

2016-06-15 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331404#comment-15331404 ] Rajat Khandelwal commented on LENS-1186: Created https://reviews.apache.org/r/48719/ > Refactor

Review Request 48719: LENS-1186: Refactor exception handling in QueryServiceResource

2016-06-15 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48719/ --- Review request for lens. Bugs: LENS-1186

[jira] [Commented] (LENS-1179) Refactoring Exception handling in Resource classes

2016-06-15 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331403#comment-15331403 ] Rajat Khandelwal commented on LENS-1179: Breaking the task into multiple tasks. Will close this

[jira] [Created] (LENS-1186) Refactor exception handling in QueryServiceResource

2016-06-15 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-1186: -- Summary: Refactor exception handling in QueryServiceResource Key: LENS-1186 URL: https://issues.apache.org/jira/browse/LENS-1186 Project: Apache Lens

[jira] [Created] (LENS-1187) Refactor exception handling in MetastoreResource

2016-06-15 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-1187: -- Summary: Refactor exception handling in MetastoreResource Key: LENS-1187 URL: https://issues.apache.org/jira/browse/LENS-1187 Project: Apache Lens Issue

Re: Review Request 46437: LENS-1011: Add python client code to lens

2016-06-15 Thread Raju Bairishetti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46437/#review137683 --- Ship it! Add this to rat checks **/*.egg - Raju Bairishetti

Re: Review Request 48539: LENS-1182: Lens UI Should set database and refresh cubes pane on db switch

2016-06-15 Thread Ankeet Maini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48539/#review137680 --- Ship it! Ship It! - Ankeet Maini On June 13, 2016, 12:59

Re: Review Request 48539: LENS-1182: Lens UI Should set database and refresh cubes pane on db switch

2016-06-15 Thread Rajat Khandelwal
> On June 14, 2016, 11:16 p.m., Ankeet Maini wrote: > > lens-ui/app/components/DatabaseComponent.js, line 130 > > > > > > event will never be `string`, so we can remove this check. > > > > if (event) { >

Re: Review Request 48539: LENS-1182: Lens UI Should set database and refresh cubes pane on db switch

2016-06-15 Thread Rajat Khandelwal
> On June 14, 2016, 10:59 p.m., Ankeet Maini wrote: > > lens-ui/app/components/CubeSchemaComponent.js, line 33 > > > > > > `measure` will always be an object, or it can be a `string` also? It can be string too.