Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

2017-02-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 28, 2017, 1:29 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

2017-02-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 28, 2017, 12:33 p.m.) Review request for lens. Bugs: LENS-1389

[jira] [Commented] (LENS-1372) QueryRetryTest is flaky

2017-02-27 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887439#comment-15887439 ] Puneet Gupta commented on LENS-1372: Not sure how ctx can be null on restart.

[jira] [Commented] (LENS-1372) QueryRetryTest is flaky

2017-02-27 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887419#comment-15887419 ] Rajat Khandelwal commented on LENS-1372: [~yuzhih...@gmail.com] would you like to contribute by

[jira] [Comment Edited] (LENS-1372) QueryRetryTest is flaky

2017-02-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860099#comment-15860099 ] Ted Yu edited comment on LENS-1372 at 2/27/17 6:20 PM: ---

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

2017-02-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 27, 2017, 8:41 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

2017-02-27 Thread Rajat Khandelwal
> On Feb. 24, 2017, 11:23 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 289 > > > > > > I feel, only when part column does not exist, we should

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

2017-02-27 Thread Rajat Khandelwal
> On Feb. 27, 2017, 6:26 p.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > lines 264-265 > > > > > > Can we add comment for this part and improve the

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

2017-02-27 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review166852 ---