Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 13, 2015, 10:54 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102442 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 13, 2015, 6:16

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 12, 2015, 6:31 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, lines > > 210-213 > > > > > > let's also implement `toString` function. Implemented

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 9, 2015, 8:38 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java, > > lines 180-181 > > > > > > This can be avoided if `columnNotFound`

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102213 --- lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 12, 2015, 8:06 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 12, 2015, 8:23 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102233 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 12, 2015, 1:53

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 11, 2015, 5:31 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102029 ---

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 9, 2015, 9:08 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102034 ---

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 9, 2015, 8:38 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java, > > lines 180-181 > > > > > > This can be avoided if `columnNotFound`

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 8, 2015, 11:15 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 1, 2015, 9:07 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, line 49 > > > > > > Can we re-use `org.apache.hadoop.hive.ql.parse.JoinType` here? > >

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 9, 2015, 4:44 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 1, 2015, 9:07 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, line 84 > > > > > > Instead of String replace, can `extract` return list of indices and we

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review101207 --- lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 1, 2015, 9:07 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, lines > > 110-113 > > > > > > Instead of looping maybe we can use regexes? We may not

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Oct. 1, 2015, 2:37 p.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, line 84 > > > > > > Instead of String replace, can `extract` return list of indices and we

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review101206 --- lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Oct. 1, 2015, 8:41 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Sept. 22, 2015, 8:07 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 313 > > > > > > Instead of making a new method, I'd say make a class

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Sept. 22, 2015, 8:07 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > lines 306-308 > > > > > > can use

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Sept. 22, 2015, 1:37 p.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java, > > line 90 > > > > > > is it needed? > > Raju Bairishetti wrote: >

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Sept. 21, 2015, 6:10 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/ --- (Updated Sept. 22, 2015, 1:19 a.m.) Review request for lens, Amareshwari

Re: Review Request 38521: LENS-607: Fix Test failures in java8

> On Sept. 19, 2015, 11:06 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java, > > line 95 > > > > > > Isn't ArrayList ordered anymore? It

Re: Review Request 38521: LENS-607: Fix Test failures in java8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review99668 ---