Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-14 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/#review149013 --- Ship it! Ship It! - Puneet Gupta On Sept. 14, 2016, 2:55

Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-14 Thread Srikanth Sundarrajan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/ --- (Updated Sept. 14, 2016, 2:55 p.m.) Review request for lens. Changes ---

Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-14 Thread Rajat Khandelwal
> On Sept. 13, 2016, 6:36 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 120 > > > > > > Just had one thought. Is there a way to keep the number of public > >

Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-14 Thread Puneet Gupta
> On Sept. 13, 2016, 1:06 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 120 > > > > > > Just had one thought. Is there a way to keep the number of public > >

Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-14 Thread Srikanth Sundarrajan
> On Sept. 13, 2016, 1:06 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 120 > > > > > > Just had one thought. Is there a way to keep the number of public > >

Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-13 Thread Srikanth Sundarrajan
> On Sept. 13, 2016, 1:06 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 120 > > > > > > Just had one thought. Is there a way to keep the number of public > >

Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-13 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/#review148713 --- lens-client/src/main/java/org/apache/lens/client/LensClient.java

Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query

2016-09-09 Thread Srikanth Sundarrajan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/ --- Review request for lens. Bugs: LENS-1319