Re: Review Request 55715: Update error message for data completeness check

2017-01-26 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/#review163226 --- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 25,

Re: Review Request 55715: Update error message for data completeness check

2017-01-25 Thread Narayan Periwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/ --- (Updated Jan. 25, 2017, 4:01 p.m.) Review request for lens. Bugs: LENS-1384

Re: Review Request 55715: Update error message for data completeness check

2017-01-24 Thread Narayan Periwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/ --- (Updated Jan. 25, 2017, 7:31 a.m.) Review request for lens. Bugs: LENS-1384

Re: Review Request 55715: Update error message for data completeness check

2017-01-24 Thread Puneet Gupta
> On Jan. 19, 2017, 2:06 p.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, > > line 151 > > > > > > Should we say > > > > "Data for the

Re: Review Request 55715: Update error message for data completeness check

2017-01-24 Thread Narayan Periwal
> On Jan. 24, 2017, 8:32 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 975 > > > > > > Can you add assert for actual messsage containing

Re: Review Request 55715: Update error message for data completeness check

2017-01-24 Thread Narayan Periwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/ --- (Updated Jan. 25, 2017, 6:29 a.m.) Review request for lens. Bugs: LENS-1384

Re: Review Request 55715: Update error message for data completeness check

2017-01-20 Thread Narayan Periwal
> On Jan. 19, 2017, 2:06 p.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, > > line 154 > > > > > > Are we logging the old more verbose message( metric

Re: Review Request 55715: Update error message for data completeness check

2017-01-19 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/#review162281 ---

Review Request 55715: Update error message for data completeness check

2017-01-19 Thread Narayan Periwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/ --- Review request for lens. Bugs: LENS-1384