Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review167053 --- Ship it! Ship It! - Puneet Gupta On Feb. 28, 2017, 12:32

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 28, 2017, 6:02 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 28, 2017, 5:06 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

> On Feb. 28, 2017, 2:45 p.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, > > line 1149 > > > > > > Is this needed ? No, but we are doing

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review167026 ---

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 28, 2017, 1:29 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 28, 2017, 12:33 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 27, 2017, 8:41 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

> On Feb. 24, 2017, 11:23 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 289 > > > > > > I feel, only when part column does not exist, we should

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

> On Feb. 27, 2017, 6:26 p.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > lines 264-265 > > > > > > Can we add comment for this part and improve the

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review166852 ---

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

> On Feb. 24, 2017, 11:23 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java, line > > 334 > > > > > > Should we make this method public ? Can be made later. So far

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 24, 2017, 7:18 p.m.) Review request for lens. Bugs: LENS-1389

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review166637 --- Some of the old comments also need to be addressed/closed

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/ --- (Updated Feb. 23, 2017, 3:24 p.m.) Review request for lens. Summary