[jira] [Updated] (LENS-1030) Query log is having other request logs

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1030:
--
Attachment: LENS-1030.2.patch

Fixed lens-site.xml in tests.

> Query log is having other request logs
> --
>
> Key: LENS-1030
> URL: https://issues.apache.org/jira/browse/LENS-1030
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.6
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-1030.2.patch, LENS-1030.patch
>
>
> Query log file has the following lines :
> {noformat}
> 3 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] 
> [grizzly-http-server-4] INFO  
> org.apache.lens.server.query.QueryExecutionServiceImpl - Returning handle 
> c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Processing 
> query:cube select 
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Added to 
> waiting queries. QueryId:c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:20:21 [0a5c1066-8927-4ed9-8f29-f89943d089e2] 
> [grizzly-http-server-4] INFO  org.apache.lens.server.AuthenticationFilter - 
> Request from user: null , path=metastore/cubes/rrcube/latestdate
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ApacheCon: Getting the word out internally

[Melissa Warnkin]

ApacheCon: Getting the word out internally
Dear Apache Enthusiast,

As you are no doubt already aware, we will be holding ApacheCon in
Seville, Spain, the week of November 14th, 2016. The call for papers
(CFP) for this event is now open, and will remain open until
September 9th.

The event is divided into two parts, each with its own CFP. The first
part of the event, called Apache Big Data, focuses on Big Data
projects and related technologies.

Website: http://events.linuxfoundation.org/events/apache-big-data-europe
CFP:
http://events.linuxfoundation.org/events/apache-big-data-europe/program/cfp

The second part, called ApacheCon Europe, focuses on the Apache
Software Foundation as a whole, covering all projects, community
issues, governance, and so on.

Website: http://events.linuxfoundation.org/events/apachecon-europe
CFP: http://events.linuxfoundation.org/events/apachecon-europe/program/cfp

ApacheCon is the official conference of the Apache Software
Foundation, and is the best place to meet members of your project and
other ASF projects, and strengthen your project's community.

If your organization is interested in sponsoring ApacheCon, contact Rich Bowen
at e...@apache.org  ApacheCon is a great place to find the brightest
developers in the world, and experts on a huge range of technologies.

I hope to see you in Seville!
==

Melissaon behalf of the ApacheCon Team

[jira] [Commented] (LENS-1030) Query log is having other request logs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382364#comment-15382364
 ] 

Hadoop QA commented on LENS-1030:
-

Applied patch: 
[LENS-1030.patch|https://issues.apache.org/jira/secure/attachment/12818563/LENS-1030.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/680/

> Query log is having other request logs
> --
>
> Key: LENS-1030
> URL: https://issues.apache.org/jira/browse/LENS-1030
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.6
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-1030.patch
>
>
> Query log file has the following lines :
> {noformat}
> 3 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] 
> [grizzly-http-server-4] INFO  
> org.apache.lens.server.query.QueryExecutionServiceImpl - Returning handle 
> c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Processing 
> query:cube select 
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Added to 
> waiting queries. QueryId:c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:20:21 [0a5c1066-8927-4ed9-8f29-f89943d089e2] 
> [grizzly-http-server-4] INFO  org.apache.lens.server.AuthenticationFilter - 
> Request from user: null , path=metastore/cubes/rrcube/latestdate
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1030) Query log is having other request logs

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1030:
--
Status: Patch Available  (was: In Progress)

> Query log is having other request logs
> --
>
> Key: LENS-1030
> URL: https://issues.apache.org/jira/browse/LENS-1030
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.6
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-1030.patch
>
>
> Query log file has the following lines :
> {noformat}
> 3 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] 
> [grizzly-http-server-4] INFO  
> org.apache.lens.server.query.QueryExecutionServiceImpl - Returning handle 
> c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Processing 
> query:cube select 
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Added to 
> waiting queries. QueryId:c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:20:21 [0a5c1066-8927-4ed9-8f29-f89943d089e2] 
> [grizzly-http-server-4] INFO  org.apache.lens.server.AuthenticationFilter - 
> Request from user: null , path=metastore/cubes/rrcube/latestdate
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1030) Query log is having other request logs

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1030:
--
Attachment: LENS-1030.patch

Patch after review. Review at https://reviews.apache.org/r/50120/

> Query log is having other request logs
> --
>
> Key: LENS-1030
> URL: https://issues.apache.org/jira/browse/LENS-1030
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.6
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-1030.patch
>
>
> Query log file has the following lines :
> {noformat}
> 3 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] 
> [grizzly-http-server-4] INFO  
> org.apache.lens.server.query.QueryExecutionServiceImpl - Returning handle 
> c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Processing 
> query:cube select 
> 03 May 2016 08:19:20 [c8d77c9d-481b-4b50-92b4-742cb4b3baf5] [QuerySubmitter] 
> INFO  org.apache.lens.server.query.QueryExecutionServiceImpl - Added to 
> waiting queries. QueryId:c8d77c9d-481b-4b50-92b4-742cb4b3baf5
> 03 May 2016 08:20:21 [0a5c1066-8927-4ed9-8f29-f89943d089e2] 
> [grizzly-http-server-4] INFO  org.apache.lens.server.AuthenticationFilter - 
> Request from user: null , path=metastore/cubes/rrcube/latestdate
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 50077: LENS-1216 : Add priority tests to regression

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50077/#review142556
---


Ship it!




Ship It!

- Rajat Khandelwal


On July 18, 2016, 3:41 p.m., Archana H wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50077/
> ---
> 
> (Updated July 18, 2016, 3:41 p.m.)
> 
> 
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Adding priority testcases
> 
> 
> Diffs
> -
> 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java
>  84cb310 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java
>  f60ecef 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
>  a1d75ea 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java
>  f7ec3e1 
>   
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java 
> c4763aa 
>   lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 
> dcf5e8b 
>   lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java 
> 4f28db5 
>   
> lens-regression/src/test/java/org/apache/lens/regression/ITPriorityTests.java 
> PRE-CREATION 
>   
> lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java 
> 203996b 
>   
> lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java
>  d10f011 
>   lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java 
> 8b53897 
>   
> lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java
>  f64d966 
>   
> lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java
>  7be0936 
>   
> lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java
>  ea8d7f2 
>   
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java
>  cfeae1c 
>   
> lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java
>  d6a0ba9 
>   
> lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java
>  48ea8ec 
>   
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java
>  b4846e3 
>   
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java
>  2d852fb 
> 
> Diff: https://reviews.apache.org/r/50077/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Archana H
> 
>

[jira] [Assigned] (LENS-996) Improvements in filters of query list api

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal reassigned LENS-996:
-

Assignee: Rajat Khandelwal

> Improvements in filters of query list api
> -
>
> Key: LENS-996
> URL: https://issues.apache.org/jira/browse/LENS-996
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-996) Improvements in filters of query list api

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382246#comment-15382246
 ] 

Rajat Khandelwal commented on LENS-996:
---

Created https://reviews.apache.org/r/50133/

> Improvements in filters of query list api
> -
>
> Key: LENS-996
> URL: https://issues.apache.org/jira/browse/LENS-996
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 50133: LENS-996: Improvements in filters of query list api

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
---

Review request for lens.


Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996


Repository: lens


Description
---

1. fromDate and endDate should also take human readable dates. 
DateUtil.resolveDate can be used. 
2. the status filter should be case-insensitive. 
3. (maybe) the user filter and status filter can take multiple comma separated 
values and return the union in the result.


Diffs
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 d10ad099b7220545802a3fcc7fd6e32a1c5b272a 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 2de098d5f16b3fc7f6c5cfa78c6b9a694c1d 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 803bbe3db982dc74ba2a1bdba94fc68879dcd351 

Diff: https://reviews.apache.org/r/50133/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1217) Remove old java ui server

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382201#comment-15382201
 ] 

Rajat Khandelwal commented on LENS-1217:


Created https://reviews.apache.org/r/50131/

> Remove old java ui server
> -
>
> Key: LENS-1217
> URL: https://issues.apache.org/jira/browse/LENS-1217
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-1217) Remove old java ui server

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1217 started by Rajat Khandelwal.
--
> Remove old java ui server
> -
>
> Key: LENS-1217
> URL: https://issues.apache.org/jira/browse/LENS-1217
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 50131: LENS-1217: Remove old java ui server

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
---

Review request for lens.


Bugs: LENS-1217
https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
---


Diffs
-

  lens-server/src/main/java/org/apache/lens/server/LensServer.java 
b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 
7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 
27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 
37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 
7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java 
de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java 
f8c5bf28457074072d70fdb742b0300380f0679c 
  
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 
aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-1217) Remove old java ui server

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1217:
--

 Summary: Remove old java ui server
 Key: LENS-1217
 URL: https://issues.apache.org/jira/browse/LENS-1217
 Project: Apache Lens
  Issue Type: Bug
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 50120: LENS-1030 : Fix logs flowing in query logs

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50120/#review142545
---


Ship it!




Ship It!

- Rajat Khandelwal


On July 18, 2016, 1:08 p.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50120/
> ---
> 
> (Updated July 18, 2016, 1:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1030
> https://issues.apache.org/jira/browse/LENS-1030
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Removing MDC ids from grizzly threads upon response : Side effect of this 
> removed ids from lensserver-requests logs. (Earlier lensserver-requests.log 
> was having wrong id on request and correct id on response)
> - Added log with logging filter id sothat we can cross check logs from 
> lensserver-requests logs.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java
>  7780dff 
>   lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java 
> e982520 
>   lens-server/src/main/java/org/apache/lens/server/BaseApp.java 19de31c 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> bace84d 
>   
> lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java
>  d2f2f91 
>   
> lens-server/src/main/java/org/apache/lens/server/LensRequestLoggingFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2de098d 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  fe9163f 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/50120/diff/
> 
> 
> Testing
> ---
> 
> Verified query logs are not dumped with other logs.
> 
> This is how the log in lensserver looks now for a request : 
> 18 Jul 2016 06:34:06 [7a6e3c3d-8f4a-46c6-813b-26c55ab5e484] 
> [grizzly-http-server-3] INFO  org.apache.lens.server.LensRequestLoggingFilter 
> - Request from user: null , path=metastore/storages loggingFilter ID=4
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 49770: Core scheduler

[Rajat Khandelwal]

> On July 11, 2016, 12:24 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java,
> >  line 55
> > 
> >
> > might need to add one more case for `CLOSED` state.
> 
> Lavkesh Lahngir wrote:
> Do yo think there is a need to check CLOSED status ?

In case CLOSED comes here, we don't want it to mark it as failed. You might 
have to check through test cases whether CLOSED event comes here or not.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review141641
---


On July 15, 2016, 2:42 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 15, 2016, 2:42 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   
> lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review142352
---




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
(line 55)


Rename variable too to reflect this is status, not state.



lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
(lines 132 - 136)


Do we have test cases for this?



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 1116)


Let's mention unit too in the property name. probably `current.time.millis`



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 55)


`@returns`



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 (line 19)


`server.api.scheduler`



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 (line 54)


Can we call it `State` instead of `STATE`?



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 (line 185)


Same as above: Let's name it `Event` instead of `EVENT`.



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
 (line 19)


`org.apache.lens.server.api.scheduler`



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
 (line 54)


`State`. http://stackoverflow.com/a/3069863/459384



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 92)


This might be confusing. In listing queries, there's a form param named 
`state`. Here, we have one named `status`.



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 204)


Can we return some more helpful info for the user? When will the operation 
not be successful?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
(lines 140 - 144)


Mismatch. One place uses `state`, another uses `status`.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 35)


Let's take the value from configutation. We might need an option to 
dynamically size the scheduler event listener depending on scale.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 84)


Let's try to use `QueryExecutionService` instead of `Impl`



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 93)


Same as above



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 116)


Shall we move line 97 to here? There is no use uf `currentTime` between 
there and here.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 135)


Can we remove this? If not, can you provide some more details in the 
comment itself wrt what handling is required?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 148)


Shall we move the `nextTransition` method to the enum instead of the 
`State` object? That way, creating such new instances can be avoided.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 (line 58)


+1



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 (line 151)


We might want to estimate with fail-on-partial set to false.



lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 (line 19)


we have another utility class `org.apache.lens.server.util.UtilityMethods`. 
Let's merge this class into that.


- Rajat Khandelwal


On July 15, 2016, 2:42 p.m., Lavkesh Lahngir wrote:
> 
> 

Re: Review Request 50077: LENS-1216 : Add priority tests to regression

[Archana H]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50077/
---

(Updated July 18, 2016, 10:11 a.m.)


Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.


Repository: lens


Description
---

Adding priority testcases


Diffs (updated)
-

  
lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java
 84cb310 
  
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java
 f60ecef 
  
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
 a1d75ea 
  
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java
 f7ec3e1 
  lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java 
c4763aa 
  lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 
dcf5e8b 
  lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java 
4f28db5 
  lens-regression/src/test/java/org/apache/lens/regression/ITPriorityTests.java 
PRE-CREATION 
  lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java 
203996b 
  
lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java 
d10f011 
  lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java 
8b53897 
  
lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java
 f64d966 
  
lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java
 7be0936 
  
lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java
 ea8d7f2 
  
lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java
 cfeae1c 
  
lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java
 d6a0ba9 
  
lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java
 48ea8ec 
  
lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java
 b4846e3 
  
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java
 2d852fb 

Diff: https://reviews.apache.org/r/50077/diff/


Testing
---


Thanks,

Archana H

Review Request 50120: LENS-1030 : Fix logs flowing in query logs

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50120/
---

Review request for lens.


Bugs: LENS-1030
https://issues.apache.org/jira/browse/LENS-1030


Repository: lens


Description
---

Changes include :
- Removing MDC ids from grizzly threads upon response : Side effect of this 
removed ids from lensserver-requests logs. (Earlier lensserver-requests.log was 
having wrong id on request and correct id on response)
- Added log with logging filter id sothat we can cross check logs from 
lensserver-requests logs.


Diffs
-

  
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java
 7780dff 
  lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java 
e982520 
  lens-server/src/main/java/org/apache/lens/server/BaseApp.java 19de31c 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java bace84d 
  
lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java
 d2f2f91 
  
lens-server/src/main/java/org/apache/lens/server/LensRequestLoggingFilter.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 2de098d 
  lens-server/src/main/resources/lensserver-default.xml 6dc322e 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
 fe9163f 
  src/site/apt/admin/config.apt 5b76069 

Diff: https://reviews.apache.org/r/50120/diff/


Testing
---

Verified query logs are not dumped with other logs.

This is how the log in lensserver looks now for a request : 
18 Jul 2016 06:34:06 [7a6e3c3d-8f4a-46c6-813b-26c55ab5e484] 
[grizzly-http-server-3] INFO  org.apache.lens.server.LensRequestLoggingFilter - 
Request from user: null , path=metastore/storages loggingFilter ID=4


Thanks,

Amareshwari Sriramadasu