Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal
> On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 35 > > > > > > Will it be measure names here or measure

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/ --- (Updated Sept. 29, 2016, 6:34 a.m.) Review request for lens. Bugs: LENS-1340

[jira] [Commented] (LENS-743) Query failure retries for transient errors

2016-09-29 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532095#comment-15532095 ] Rajat Khandelwal commented on LENS-743: --- More changes: h4. Query API changes Details api will return

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Sept. 29, 2016, 2:39 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150832 ---

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-09-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52341/#review150831 ---

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/ --- (Updated Sept. 29, 2016, 10:27 a.m.) Review request for lens. Bugs:

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal
> On Sept. 29, 2016, 10:02 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 30 > > > > > > Can you also describe significance of

Review Request 52381: LENS-1273 : Resolve issues with case when aggregate expressions with dim-attributes conditions

2016-09-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52381/ --- Review request for lens and Rajat Khandelwal. Bugs: LENS-1273

Re: [VOTE] Release of Apache Lens 2.6.1

2016-09-29 Thread Rajat Khandelwal
Build passed. Tried running examples, and got errors as Amareshwari mentioned. Won't block release for this, +1 from my side for releasing.