Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-09 Thread Amruth Sampath 


On Sept. 9, 2015, 10:46 a.m., Amruth Sampath wrote:
> > Overall changes look fine.
> > Can you add one section in user doc explaining the feature ?

Sure. Where is the user doc?


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
---


On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 8, 2015, 6:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  720825a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 5d77eb7 
>   lens-server/src/main/resources/lensserver-default.xml 5d33eda 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  2189eb8 
>   
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
>  PRE-CREATION 
>   lens-server/src/test/resources/lens-site.xml 4cf94d5 
> 
> Diff: https://reviews.apache.org/r/37934/diff/
> 
> 
> Testing
> ---
> 
> Have added unit test cases for parsing, resolution of parameter and service 
> testing.
> 
> 
> Thanks,
> 
> Amruth

[jira] [Commented] (LENS-392) Look ahead should take how much time to look ahead, instead of just a number

2015-09-09 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736597#comment-14736597
 ] 

Rajat Khandelwal commented on LENS-392:
---

Created https://reviews.apache.org/r/38212/

> Look ahead should take how much time to look ahead, instead of just a number
> 
>
> Key: LENS-392
> URL: https://issues.apache.org/jira/browse/LENS-392
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-09 Thread Amareshwari Sriramadasu 


On Sept. 9, 2015, 10:46 a.m., Amruth Sampath wrote:
> > Overall changes look fine.
> > Can you add one section in user doc explaining the feature ?
> 
> Amruth Sampath wrote:
> Sure. Where is the user doc?

src/site/api/user/index.apt


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
---


On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 8, 2015, 6:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  720825a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 5d77eb7 
>   lens-server/src/main/resources/lensserver-default.xml 5d33eda 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  2189eb8 
>   
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
>  PRE-CREATION 
>   lens-server/src/test/resources/lens-site.xml 4cf94d5 
> 
> Diff: https://reviews.apache.org/r/37934/diff/
> 
> 
> Testing
> ---
> 
> Have added unit test cases for parsing, resolution of

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-09 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 (line 26)


Why is this extending Throwable? and not extedning LensException for giving 
the error out?



lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 (line 89)


Please add javadoc for all methods and explaining params.



lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 (line 92)


Have the variable names same as param names, sothat auto generated docs 
match.

Please verify autugenerated docs for the new resource by running

'mvn enunciate:docs' - all docs are fine.



lens-server/src/main/resources/lensserver-default.xml (line 769)


Update config.apt by running tests in lens-api



lens-server/src/test/resources/lens-site.xml (line 143)


Update description to HSQL


Overall changes look fine.
Can you add one section in user doc explaining the feature ?

- Amareshwari Sriramadasu


On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 8, 2015, 6:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  720825a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
>

[jira] [Commented] (LENS-756) Example query on customer_city_name failing

2015-09-09 Thread Amareshwari Sriramadasu (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738174#comment-14738174
 ] 

Amareshwari Sriramadasu commented on LENS-756:
--

I tried to fix this, but does not seem straightforward : Created LENS-771 for 
tracking. Planning to remove multiple chain ref columns from customer_city_name 
for examples to pass, as part of this jira.

> Example query on customer_city_name failing
> ---
>
> Key: LENS-756
> URL: https://issues.apache.org/jira/browse/LENS-756
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube, examples
>Affects Versions: 2.3
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.4
>
>
> Query:cube select customer_city_name, store_sales from sales where 
> time_range_in(delivery_time, '2015-04-12-00', '2015-04-13-00')
> Total time for running examples(in millis) :1216047
> Exception in thread "main" 
> LensAPIException(errorResult=LensAPIResult(apiVersion=null, 
> id=8f82a87d-249c-41ef-9e26-80fd6aef1355, data=null, 
> lensErrorTO=LensErrorTO(code=1001, message=Internal Server Error., 
> stackTrace=org.apache.lens.server.api.error.LensException:  Driver 
> :org.apache.lens.driver.jdbc.JDBCDriver Cause :No dimension table has the 
> queried columns for customer, columns: [id, city_id]
>  Driver :org.apache.lens.driver.hive.HiveDriver Cause :No dimension table has 
> the queried columns for customer, columns: [id, city_id]
>   at 
> org.apache.lens.server.query.QueryExecutionServiceImpl.rewriteAndSelect(QueryExecutionServiceImpl.java:1283)
>   at 
> org.apache.lens.server.query.QueryExecutionServiceImpl.executeAsyncInternal(QueryExecutionServiceImpl.java:1696)
>   at 
> org.apache.lens.server.query.QueryExecutionServiceImpl.executeAsync(QueryExecutionServiceImpl.java:1647)
>   at 
> org.apache.lens.server.query.QueryServiceResource.query(QueryServiceResource.java:226)
>   at sun.reflect.GeneratedMethodAccessor44.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:601)
>   at 
> org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
>   at 
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:151)
>   at 
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:171)
>   at 
> org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$TypeOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:195)
>   at 
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:104)
>   at 
> org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:353)
>   at 
> org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:343)
>   at 
> org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:102)
>   at 
> org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:255)
>   at org.glassfish.jersey.internal.Errors$1.call(Errors.java:271)
>   at org.glassfish.jersey.internal.Errors$1.call(Errors.java:267)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
>   at org.glassfish.jersey.internal.Errors.process(Errors.java:267)
>   at 
> org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:318)
>   at 
> org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:235)
>   at 
> org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:983)
>   at 
> org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:330)
>   at 
> org.glassfish.grizzly.http.server.HttpHandler$1.run(HttpHandler.java:212)
>   at 
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:565)
>   at 
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:545)
>   at java.lang.Thread.run(Thread.java:722)
> , payload=null, childErrors=null), httpStatusCode=null))
>   at 
> org.apache.lens.client.LensStatement.executeQuery(LensStatement.java:309)
>   at 
> org.apache.lens.client.LensStatement.executeQuery(LensStatement.java:99)
>   at 
> org.apache.lens.examples.SampleQueries.runQueries(SampleQueries.java:135)
>   at 
>