Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150811
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 32)


Give more details about what does tag mean here.



lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 34)


Mention end date is exclusive



lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 35)


Will it be measure names here or measure tags?



lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 38)


Should start and end dates be string to accept relative ranges like 
now.day-2days and etc ?

If so, we should fix the format for passing date fields as string.


- Amareshwari Sriramadasu


On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 28, 2016, 9:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>



Re: Review Request 52040: Handling data delay

2016-09-28 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review150810
---




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 (line 58)


I'm still wondering if there should be a LAUNCHED state for 
ON_CONDITIONS_MET.


- Amareshwari Sriramadasu


On Sept. 26, 2016, 9:53 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 26, 2016, 9:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   lens-server/src/main/resources/lensserver-default.xml 
> 84ff9f9e42015da570eae94bf9748aa090417bae 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
>   src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>



Re: [VOTE] Release of Apache Lens 2.6.1

2016-09-28 Thread Raju Bairishetti
+1(binding)  from my side

Verified checksum, signatures and nexus repo.
Able to build successfully from source.

just a minor note, contrib/*.pom.xml.**swp* file exists in the source
release package. I think we can ignore this.


On Wed, Sep 28, 2016 at 5:00 PM, Puneet Gupta 
wrote:

> Guys, I will be traveling. Will be back after a week.
> In my absence Rajat Khandelwal will take care of 2.6.1 release
>
> Thanks,
> Puneet Gupta
>
> On Wed, Sep 28, 2016 at 2:24 PM, Amareshwari Sriramdasu <
> amareshw...@apache.org> wrote:
>
> > +1 to release the candidate. But found a couple of issues with release
> > which are noted down.
> >
> > Verified the following :
> > + Jars in Nexus repo  : Good.
> > + Signatures : Good
> > + Checksums : Good
> > + No unexpected binaries found in the source release.
> > + NOTICE is good.
> > + Building from source : Successful
> > - LICENSE issues : found an issue with one of the files
> > : ./lens-ui/app/dispatcher/AppDispatcher.js
> > The file is having copyright from Facebook and text says the license is
> BSD
> > style which is in root directory of the source. But I don't see any
> > corresponding license in root directory of the source. Seems the file is
> > added in 2.5 release itself, but we need to put its corresponding license
> > to top level LICENSE file. I'm fine fixing it in next release.
> > - Ran examples from binary distribution : Seeing all cube queries are
> > failing. Not sure if the issue is only with examples.
> >
> > 
> >
> > Successful queries 14 out of 151queries
> >
> > Total time for running examples(in millis) :39462
> >
> > ---
> >
> > Thanks
> > Amareshwari
> >
> > On Tue, Sep 27, 2016 at 7:43 PM, Puneet Gupta 
> > wrote:
> >
> > > Hi everyone,
> > >
> > > I propose the following RC to be released as official Apache Lens 2.6.1
> > > release.
> > >
> > > The commit id is 7224d832de56ac7a22a06bb285808cfac33f32f2:
> > > http://git-wip-us.apache.org/repos/asf/lens/commit/7224d832d
> > >
> > > This corresponds to the tag: apache-lens-2.6.1:
> > > https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r
> > > efs/tags/apache-lens-2.6.1
> > >
> > > Release archives (tar.gz/.zip), signature, and checksums are here:
> > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/
> > >
> > > You can find the KEYS file here:
> > > https://dist.apache.org/repos/dist/release/lens/KEYS
> > >
> > > The release candidate consists of the following source distribution
> > archive
> > > apache-lens-2.6.1-source-release.zip:
> > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.
> > > 1-rc0/apache-lens-2.6.1-source-release.zip
> > >
> > > In addition, the following supplementary binary distributions are
> > provided
> > > for user convenience at the same location:apache-lens-2.6.1-
> bin.tar.gz:
> > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.
> > > 1-rc0/apache-lens-2.6.1-bin.tar.gz
> > >
> > > The licensing of bundled bits in the archives are documented at
> > > https://cwiki.apache.org/confluence/display/LENS/
> > Licensing+in+Apache+Lens
> > >
> > > Nexus staging url:
> > > https://repository.apache.org/content/repositories/orgapachelens-1010/
> > >
> > > Release notes available at
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> > > ctId=12315923=12333846
> > >
> > >
> > > Vote will be open for at least 72 hours
> > >
> > > [ ] +1 approve
> > > [ ] 0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > +1 from my side for the release.
> > >
> > > For folks not familiar with vetting a release, please refer to
> > >
> > > http://incubator.apache.org/guides/releasemanagement.html#check-list
> > >
> >
>



-- 

--
Thanks,
Raju Bairishetti,
www.lazada.com


Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-28 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52088/
---

(Updated Sept. 28, 2016, 7:47 p.m.)


Review request for lens.


Bugs: LENS-743
https://issues.apache.org/jira/browse/LENS-743


Repository: lens


Description
---

There have to be retries for query failures for transient errors like network 
errors (Hive server not reachable/ Metastore not reachable/ DB not reachable). 
Retries should be available for each phase - submission, execution, updating 
status, fetching results and formatting.

Right now, any such failure results in marking query as failed.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/FailedAttempt.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
7d079a9ed99e3d4940d5f26370547683a6bba465 
  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
daedbf9ea387cbde3ef39363c2beef3f96725223 
  lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 
fceabeae9217676774a6978212cbc9ee9ca120f7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
84d9933da506e3f1bff2d3e0ea403ed1edf0fe35 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
3bf5e8f7dc9d032e46d06c3245048096acb4572e 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 3c34eb191966dff3ac3032eb79282336b5c6789b 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java
 82b56470e2de09f7c41d1226ea59cffdd8d26a26 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
6e9086f9e8dc302ad2171d7f5636a24cb79dcb50 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
8cf617b7181b9a305ea2c68f68c610f823ee75d7 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java
 17bfba02244bca7141268ed12e4a41400e2bec82 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java
 70a34b0c0517ed3b7af46120906fb77ae57870ac 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java
 e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/OperationRetryHandlerFactory.java
 88fbe43318315394873cabb9f5dd39f09f6c47f4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 03079e2dc353fa028f3c5d5a03a8ae2dbf728004 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
e472de0a452ffbbcb217503c260aa26fe7f6ed99 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
 5ff59bd0da713651a7cc5261dbd18cd88e91fc76 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 b58fcf964cedb8dc302099ae9c806b06acafa2d3 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b584c6a6d414a6f0dac509e67c8944dbd2373325 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryQueuedForRetry.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/StatusUpdateFailureContext.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/ChainedComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/FIFOQueryComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/MoreRetriesFirstComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/QueryComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/QueryCostComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/QueryPriorityComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 e0f1376d48457d53c5c9bafa673304df4b54cc50 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/QueryLaunchingConstraint.java
 12d9562566e71477db3cf00e1e0ed84d43eeb6cc 
  
lens-server-api/src/main/java/org/apache/lens/server/api/retry/BackOffRetryHandler.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/retry/DefaultRetryPolicyDecider.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/retry/FailureContext.java
 PRE-CREATION 
  

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-28 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52088/
---

(Updated Sept. 28, 2016, 7:55 p.m.)


Review request for lens.


Bugs: LENS-743
https://issues.apache.org/jira/browse/LENS-743


Repository: lens


Description
---

There have to be retries for query failures for transient errors like network 
errors (Hive server not reachable/ Metastore not reachable/ DB not reachable). 
Retries should be available for each phase - submission, execution, updating 
status, fetching results and formatting.

Right now, any such failure results in marking query as failed.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/FailedAttempt.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
7d079a9ed99e3d4940d5f26370547683a6bba465 
  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
daedbf9ea387cbde3ef39363c2beef3f96725223 
  lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 
fceabeae9217676774a6978212cbc9ee9ca120f7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
84d9933da506e3f1bff2d3e0ea403ed1edf0fe35 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
3bf5e8f7dc9d032e46d06c3245048096acb4572e 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 3c34eb191966dff3ac3032eb79282336b5c6789b 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java
 82b56470e2de09f7c41d1226ea59cffdd8d26a26 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
6e9086f9e8dc302ad2171d7f5636a24cb79dcb50 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
8cf617b7181b9a305ea2c68f68c610f823ee75d7 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java
 17bfba02244bca7141268ed12e4a41400e2bec82 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java
 70a34b0c0517ed3b7af46120906fb77ae57870ac 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java
 e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/OperationRetryHandlerFactory.java
 88fbe43318315394873cabb9f5dd39f09f6c47f4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 03079e2dc353fa028f3c5d5a03a8ae2dbf728004 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
e472de0a452ffbbcb217503c260aa26fe7f6ed99 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
 5ff59bd0da713651a7cc5261dbd18cd88e91fc76 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 b58fcf964cedb8dc302099ae9c806b06acafa2d3 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/PriorityChange.java
 eaf3fee953e1efbcf151fc844a9441b74b84cc3e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryAccepted.java
 8980b619c9feb86be326bf799fecc35c1579c763 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java
 a473a47606df84e2b5b204478ad63e63e69b0c23 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java 
3837087db6e51c1606573511bfc02b6108d1ef3d 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b584c6a6d414a6f0dac509e67c8944dbd2373325 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 
e80da6d2a417e1274fb186153ec01615c2da565b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 
81c53be905d015bd14c0a05de5c7a43f8a6c5d84 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecuted.java
 af8c8ee062c4c43ae987cea7316a36d84215d389 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryFailed.java 
bdffbc2f37bae7a59add1ee3823de87887483e5e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryLaunched.java
 5fcdd73899e3d8c8368fdc42ff6cc9912323e5ee 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryQueued.java 
5f347ad0e751d9cfc6b647d57d0acc25fd8dee01 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRejected.java
 c4e60e3d72108bb556f6cd9a5887230b39d67a02 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRunning.java
 52aa50d60cd2c1c03a76351830de2942ee84687d 
  

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-09-28 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/
---

(Updated Sept. 28, 2016, 11:18 a.m.)


Review request for lens.


Changes
---

Updated testing messages


Bugs: lens-1325
https://issues.apache.org/jira/browse/lens-1325


Repository: lens


Description
---

1. Added test cases to test multiple query parsms 
2. Test with complex param value that requires encoding at the time of 
submission


Diffs
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
 f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508529f6745caadd8eee0f63e81e1f14ed75 

Diff: https://reviews.apache.org/r/52341/diff/


Testing (updated)
---

mvn  test 
-Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" 
-pl lens-server


 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


**Logs form TestQueryNotifictaionResource show params access_token and data are 
recived correctly** 

lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:null
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
--
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log


**Logs from lens server show succes for both the urls**

puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
successfully" lens-server/target/test.log
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
 Response code 204
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123=x%3C%3Eyz%2C%22abc.
 Response code 204


Thanks,

Puneet Gupta



Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-09-28 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/
---

Review request for lens.


Bugs: lens-1325
https://issues.apache.org/jira/browse/lens-1325


Repository: lens


Description
---

1. Added test cases to test multiple query parsms 
2. Test with complex param value that requires encoding at the time of 
submission


Diffs
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
 f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508529f6745caadd8eee0f63e81e1f14ed75 

Diff: https://reviews.apache.org/r/52341/diff/


Testing
---

mvn  test 
-Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" 
-pl lens-server


 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


**Logs form TestQueryNotifictaionResource show params access_token and data are 
recived correctly 

lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:null
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
--
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log


Thanks,

Puneet Gupta



[jira] [Work started] (LENS-1325) Support encoded urls for query HTTP notifications

2016-09-28 Thread Puneet Gupta (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1325 started by Puneet Gupta.
--
> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LENS-743) Query failure retries for transient errors

2016-09-28 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529044#comment-15529044
 ] 

Rajat Khandelwal commented on LENS-743:
---

It will retry only on d3. That is also dependent on whether server retry policy 
allows more than one retry (since according to server retry policy, one retry 
has been done while trying on d2). 



> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: gsoc2016, java
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Narayan Periwal


> On Sept. 28, 2016, 8:59 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 34
> > 
> >
> > Please add java for all method params, describing what they are.

Added documentation for all method params.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150695
---


On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 28, 2016, 9:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>



Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Narayan Periwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/
---

(Updated Sept. 28, 2016, 9:25 a.m.)


Review request for lens.


Bugs: LENS-1340
https://issues.apache.org/jira/browse/LENS-1340


Repository: lens


Description
---

The data completeness API will take the factTag, startDate, endDate and 
measure's list as input. 
It will return the completeness percentage for each of the measures for the 
given factTag and time range.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52259/diff/


Testing
---


Thanks,

Narayan Periwal



Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Amareshwari Sriramadasu


> On Sept. 26, 2016, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 32
> > 
> >
> > What interval are the keys in the map spaced over?
> > 
> > Perhaps we need an UpdatePeriod argument?
> > 
> > Also, do keep in mind that end date should be exclusive. 
> > 
> > And, if we are passing start, end and UpdatePeriod, it might be better 
> > to use `org.apache.lens.cube.metadata.TimePartitionRange`
> 
> Narayan Periwal wrote:
> Keys are spaced over hourly intervals, this is fixed. 
> Sure, will take care of this fact that end date is exclusive.

I would not recommend using org.apache.lens.cube.metadata.TimePartitionRange, 
as those are not public classes.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150396
---


On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 1:03 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>



Re: [VOTE] Release of Apache Lens 2.6.1

2016-09-28 Thread Puneet Gupta
Guys, I will be traveling. Will be back after a week.
In my absence Rajat Khandelwal will take care of 2.6.1 release

Thanks,
Puneet Gupta

On Wed, Sep 28, 2016 at 2:24 PM, Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> +1 to release the candidate. But found a couple of issues with release
> which are noted down.
>
> Verified the following :
> + Jars in Nexus repo  : Good.
> + Signatures : Good
> + Checksums : Good
> + No unexpected binaries found in the source release.
> + NOTICE is good.
> + Building from source : Successful
> - LICENSE issues : found an issue with one of the files
> : ./lens-ui/app/dispatcher/AppDispatcher.js
> The file is having copyright from Facebook and text says the license is BSD
> style which is in root directory of the source. But I don't see any
> corresponding license in root directory of the source. Seems the file is
> added in 2.5 release itself, but we need to put its corresponding license
> to top level LICENSE file. I'm fine fixing it in next release.
> - Ran examples from binary distribution : Seeing all cube queries are
> failing. Not sure if the issue is only with examples.
>
> 
>
> Successful queries 14 out of 151queries
>
> Total time for running examples(in millis) :39462
>
> ---
>
> Thanks
> Amareshwari
>
> On Tue, Sep 27, 2016 at 7:43 PM, Puneet Gupta 
> wrote:
>
> > Hi everyone,
> >
> > I propose the following RC to be released as official Apache Lens 2.6.1
> > release.
> >
> > The commit id is 7224d832de56ac7a22a06bb285808cfac33f32f2:
> > http://git-wip-us.apache.org/repos/asf/lens/commit/7224d832d
> >
> > This corresponds to the tag: apache-lens-2.6.1:
> > https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r
> > efs/tags/apache-lens-2.6.1
> >
> > Release archives (tar.gz/.zip), signature, and checksums are here:
> > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/
> >
> > You can find the KEYS file here:
> > https://dist.apache.org/repos/dist/release/lens/KEYS
> >
> > The release candidate consists of the following source distribution
> archive
> > apache-lens-2.6.1-source-release.zip:
> > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.
> > 1-rc0/apache-lens-2.6.1-source-release.zip
> >
> > In addition, the following supplementary binary distributions are
> provided
> > for user convenience at the same location:apache-lens-2.6.1-bin.tar.gz:
> > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.
> > 1-rc0/apache-lens-2.6.1-bin.tar.gz
> >
> > The licensing of bundled bits in the archives are documented at
> > https://cwiki.apache.org/confluence/display/LENS/
> Licensing+in+Apache+Lens
> >
> > Nexus staging url:
> > https://repository.apache.org/content/repositories/orgapachelens-1010/
> >
> > Release notes available at
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> > ctId=12315923=12333846
> >
> >
> > Vote will be open for at least 72 hours
> >
> > [ ] +1 approve
> > [ ] 0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > +1 from my side for the release.
> >
> > For folks not familiar with vetting a release, please refer to
> >
> > http://incubator.apache.org/guides/releasemanagement.html#check-list
> >
>


Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150695
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 34)


Please add java for all method params, describing what they are.


- Amareshwari Sriramadasu


On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 1:03 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>



Fwd: [VOTE] Release of Apache Lens 2.6.1

2016-09-28 Thread Amareshwari Sriramdasu
+1 to release the candidate. But found a couple of issues with release
which are noted down.

Verified the following :
+ Jars in Nexus repo  : Good.
+ Signatures : Good
+ Checksums : Good
+ No unexpected binaries found in the source release.
+ NOTICE is good.
+ Building from source : Successful
- LICENSE issues : found an issue with one of the files
: ./lens-ui/app/dispatcher/AppDispatcher.js
The file is having copyright from Facebook and text says the license is BSD
style which is in root directory of the source. But I don't see any
corresponding license in root directory of the source. Seems the file is
added in 2.5 release itself, but we need to put its corresponding license
to top level LICENSE file. I'm fine fixing it in next release.
- Ran examples from binary distribution : Seeing all cube queries are
failing. Not sure if the issue is only with examples.



Successful queries 14 out of 151queries

Total time for running examples(in millis) :39462

---

Thanks
Amareshwari

On Tue, Sep 27, 2016 at 7:43 PM, Puneet Gupta 
wrote:

> Hi everyone,
>
> I propose the following RC to be released as official Apache Lens 2.6.1
> release.
>
> The commit id is 7224d832de56ac7a22a06bb285808cfac33f32f2:
> http://git-wip-us.apache.org/repos/asf/lens/commit/7224d832d
>
> This corresponds to the tag: apache-lens-2.6.1:
> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r
> efs/tags/apache-lens-2.6.1
>
> Release archives (tar.gz/.zip), signature, and checksums are here:
> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/
>
> You can find the KEYS file here:
> https://dist.apache.org/repos/dist/release/lens/KEYS
>
> The release candidate consists of the following source distribution archive
> apache-lens-2.6.1-source-release.zip:
> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.
> 1-rc0/apache-lens-2.6.1-source-release.zip
>
> In addition, the following supplementary binary distributions are provided
> for user convenience at the same location:apache-lens-2.6.1-bin.tar.gz:
> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.
> 1-rc0/apache-lens-2.6.1-bin.tar.gz
>
> The licensing of bundled bits in the archives are documented at
> https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens
>
> Nexus staging url:
> https://repository.apache.org/content/repositories/orgapachelens-1010/
>
> Release notes available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> ctId=12315923=12333846
>
>
> Vote will be open for at least 72 hours
>
> [ ] +1 approve
> [ ] 0 no opinion
> [ ] -1 disapprove (and reason why)
>
> +1 from my side for the release.
>
> For folks not familiar with vetting a release, please refer to
>
> http://incubator.apache.org/guides/releasemanagement.html#check-list
>


Re: Review Request 52337: LENS-1324: Support more hooks in DriverQueryHook

2016-09-28 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52337/#review150694
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Sept. 28, 2016, 7:04 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52337/
> ---
> 
> (Updated Sept. 28, 2016, 7:04 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1324
> https://issues.apache.org/jira/browse/lens-1324
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently we have two hooks 
> 1. preLaunch
> 2. postDriverSelection
> 
> Need to add some hooks that can hook into rewrite and estimate flow also. 
> 1.preRewrite, postRewrite
> 2.preEstimate,postEstimate
> 
> NoOpDriverQueryHook will have default empty implementation for these new 
> methods .
> 
> Also added  void setDriver(LensDriver driver) in Driver Hook to pass the 
> driver information.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 84d9933 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 3bf5e8f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  03079e2 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  da125bd 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  8cd03cb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  792508b 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
>  168b3cc 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
>  0c4a3f0 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  0bb106e 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f755508 
> 
> Diff: https://reviews.apache.org/r/52337/diff/
> 
> 
> Testing
> ---
> 
> ---
>  T E S T S
> ---
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.906 sec - 
> in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:41 min
> [INFO] Finished at: 2016-09-28T11:47:07+05:30
> [INFO] Final Memory: 133M/1482M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>



[jira] [Created] (LENS-1341) UnmarshalException while reading response of saved query getParameters() call

2016-09-28 Thread Archana H (JIRA)
Archana H created LENS-1341:
---

 Summary: UnmarshalException while reading response of saved query 
getParameters() call
 Key: LENS-1341
 URL: https://issues.apache.org/jira/browse/LENS-1341
 Project: Apache Lens
  Issue Type: Bug
Reporter: Archana H


POST call on "/queryapi/savedqueries/parameters" will throw UnmarshalException 
while reading response, as it expects all members of Parameter object to be non 
null where as in this case only name is getting initialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 52337: LENS-1324: Support more hooks in DriverQueryHook

2016-09-28 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52337/
---

(Updated Sept. 28, 2016, 7:04 a.m.)


Review request for lens.


Changes
---

Fixed Checkstyle


Bugs: lens-1324
https://issues.apache.org/jira/browse/lens-1324


Repository: lens


Description
---

Currently we have two hooks 
1. preLaunch
2. postDriverSelection

Need to add some hooks that can hook into rewrite and estimate flow also. 
1.preRewrite, postRewrite
2.preEstimate,postEstimate

NoOpDriverQueryHook will have default empty implementation for these new 
methods .

Also added  void setDriver(LensDriver driver) in Driver Hook to pass the driver 
information.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
84d9933 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
3bf5e8f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 03079e2 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 da125bd 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 8cd03cb 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
 792508b 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
168b3cc 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 0c4a3f0 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 0bb106e 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508 

Diff: https://reviews.apache.org/r/52337/diff/


Testing
---

---
 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.906 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 04:41 min
[INFO] Finished at: 2016-09-28T11:47:07+05:30
[INFO] Final Memory: 133M/1482M
[INFO] 


Thanks,

Puneet Gupta



Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries

2016-09-28 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52028/#review150689
---


Fix it, then Ship it!




Ship It!


lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 
84)


Can we confirm that before this patch createFinishedQueriesTable() was not 
creating a table for a non in-memory database since there is no explicit commit 
statement and auto commit was turned off ?

Test cases seem to pass, but then we use in-memory dbs for test cases.


- Puneet Gupta


On Sept. 19, 2016, 11:35 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52028/
> ---
> 
> (Updated Sept. 19, 2016, 11:35 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1308
> https://issues.apache.org/jira/browse/LENS-1308
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
> 2ec938e951522b3026f6485ff900268d6e0039cd 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 90226d121b5a1ca50e3fcb786437a9198d97a692 
> 
> Diff: https://reviews.apache.org/r/52028/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



[jira] [Commented] (LENS-1324) Support more hooks in DriverQueryHook

2016-09-28 Thread Puneet Gupta (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528607#comment-15528607
 ] 

Puneet Gupta commented on LENS-1324:


https://reviews.apache.org/r/52337/

> Support more hooks in DriverQueryHook
> -
>
> Key: LENS-1324
> URL: https://issues.apache.org/jira/browse/LENS-1324
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
>
> Currently we have two hooks 
> 1. preLaunch
> 2. postDriverSelection
> Need to add some hooks that can hook into rewrite and estimate flow also. 
> 1.preRewrite, postRewrite
> 2.preEstimate,postEstimate
> NoOpDriverQueryHook will have default empty implementation for these new 
> methods .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 52337: LENS-1324: Support more hooks in DriverQueryHook

2016-09-28 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52337/
---

Review request for lens.


Bugs: lens-1324
https://issues.apache.org/jira/browse/lens-1324


Repository: lens


Description
---

Currently we have two hooks 
1. preLaunch
2. postDriverSelection

Need to add some hooks that can hook into rewrite and estimate flow also. 
1.preRewrite, postRewrite
2.preEstimate,postEstimate

NoOpDriverQueryHook will have default empty implementation for these new 
methods .

Also added  void setDriver(LensDriver driver) in Driver Hook to pass the driver 
information.


Diffs
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
84d9933da506e3f1bff2d3e0ea403ed1edf0fe35 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
3bf5e8f7dc9d032e46d06c3245048096acb4572e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 03079e2dc353fa028f3c5d5a03a8ae2dbf728004 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 da125bd920aea82dc910fad92290d07fcc2a2387 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 8cd03cb11ae88413973a9fc384fd828014b1aa0c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
 792508b14b9228ff20437d03f78e38165d920798 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
168b3cc8a2e32e4fddb66f480af38e77adef62c2 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 0c4a3f05ce752091d2187badf2054c3926c7c9f6 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 0bb106ed77306094710c126fc652d5c56a908d85 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508529f6745caadd8eee0f63e81e1f14ed75 

Diff: https://reviews.apache.org/r/52337/diff/


Testing
---

---
 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.906 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 04:41 min
[INFO] Finished at: 2016-09-28T11:47:07+05:30
[INFO] Final Memory: 133M/1482M
[INFO] 


Thanks,

Puneet Gupta



[jira] [Work started] (LENS-1324) Support more hooks in DriverQueryHook

2016-09-28 Thread Puneet Gupta (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1324 started by Puneet Gupta.
--
> Support more hooks in DriverQueryHook
> -
>
> Key: LENS-1324
> URL: https://issues.apache.org/jira/browse/LENS-1324
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
>
> Currently we have two hooks 
> 1. preLaunch
> 2. postDriverSelection
> Need to add some hooks that can hook into rewrite and estimate flow also. 
> 1.preRewrite, postRewrite
> 2.preEstimate,postEstimate
> NoOpDriverQueryHook will have default empty implementation for these new 
> methods .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)