Review Request 52514: Add data completeness checker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52514/ --- Review request for lens. Bugs: LENS-1333 https://issues.apache.org/jira/browse/LENS-1333 Repository: lens Description --- Though lens has partition registration being done whenever data is available, there is no guarantee the partition registered is complete. There can be different ways to know if the data is complete for partition. One option could be to have a partition property saying whether it is complete or not. Other could be to do a http call to another hosted service and more. Proposal here is to add an interface for DataCompletenessChecker and do the check while resolving partitions. Here are some of the capabilities we would like to add in Lens : # Lens will check partition existence first, if it exists, then check the completeness percentage. If the completeness percentage is less than a configured threshold (default should be 98, 99 or even 100), Lens will fail the query. # Lens's accept query on partial data will accept on incomplete data as well. # Lens will also option to override the completeness percentage threshold value at query level # Lens will still have look ahead capability of daily being incomplete, then it will union with hourly. # If same measure is there in two different facts , Lens will we pick the one with higher availability. # In case of completeness percentage threshold missed, Lens will respond back with available percentage. Diffs - .gitignore aca87dc lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java fb958c3 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 4585ef7 lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 01265a5 lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 78fb21d lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 49ed5ef lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java PRE-CREATION lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 13f1aa4 lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java db26718 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f7f8af2 lens-cube/src/test/java/org/apache/lens/cube/parse/DefaultCompletenessChecker.java PRE-CREATION lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 7afa32e Diff: https://reviews.apache.org/r/52514/diff/ Testing --- Thanks, Narayan Periwal
[jira] [Commented] (LENS-1285) Adding unit tests for scheduler API
[ https://issues.apache.org/jira/browse/LENS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545372#comment-15545372 ] Hadoop QA commented on LENS-1285: - Applied patch: [0001-Resource-tests.patch|https://issues.apache.org/jira/secure/attachment/12831517/0001-Resource-tests.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/984/ > Adding unit tests for scheduler API > --- > > Key: LENS-1285 > URL: https://issues.apache.org/jira/browse/LENS-1285 > Project: Apache Lens > Issue Type: Test >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: 0001-Resource-tests.patch, Scheduler-API-tests.patch, > Scheduler-API-tests.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (LENS-1333) Add data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1333 started by Narayan Periwal. - > Add data completeness checker > - > > Key: LENS-1333 > URL: https://issues.apache.org/jira/browse/LENS-1333 > Project: Apache Lens > Issue Type: New Feature > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Narayan Periwal > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1285) Adding unit tests for scheduler API
[ https://issues.apache.org/jira/browse/LENS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1285: -- Attachment: 0001-Resource-tests.patch > Adding unit tests for scheduler API > --- > > Key: LENS-1285 > URL: https://issues.apache.org/jira/browse/LENS-1285 > Project: Apache Lens > Issue Type: Test >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: 0001-Resource-tests.patch, Scheduler-API-tests.patch, > Scheduler-API-tests.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1285) Adding unit tests for scheduler API
[ https://issues.apache.org/jira/browse/LENS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1285: -- Status: Patch Available (was: Open) > Adding unit tests for scheduler API > --- > > Key: LENS-1285 > URL: https://issues.apache.org/jira/browse/LENS-1285 > Project: Apache Lens > Issue Type: Test >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: 0001-Resource-tests.patch, Scheduler-API-tests.patch, > Scheduler-API-tests.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (LENS-1327) Handle Data delay for scheduled jobs
[ https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542175#comment-15542175 ] Lavkesh Lahngir edited comment on LENS-1327 at 10/4/16 10:06 AM: - The new flow for the instance life cycle is Launching -> waiting -> launching -> .. -> waiting -> Launching -> Launched -> Running. It will keep coming back to the waiting state if the data is not present. was (Author: lavkesh): The new flow for the instance life cycle is Launching -> waiting-> launching -> .. -> waiting -> Launching -> Launched -> Running. It will keep coming back to the waiting state if the data is not present. > Handle Data delay for scheduled jobs > > > Key: LENS-1327 > URL: https://issues.apache.org/jira/browse/LENS-1327 > Project: Apache Lens > Issue Type: Sub-task >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: data-delay.patch, data-delay.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 51331: Test cases for scheduler api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51331/ --- (Updated Oct. 4, 2016, 10:03 a.m.) Review request for lens. Bugs: LENS-1285 https://issues.apache.org/jira/browse/LENS-1285 Repository: lens Description --- End to end test cases for Scheduler Diffs (updated) - lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 57786e6 lens-server/src/test/java/org/apache/lens/server/scheduler/ScheduleResourceTest.java PRE-CREATION Diff: https://reviews.apache.org/r/51331/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544878#comment-15544878 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.03.patch|https://issues.apache.org/jira/secure/attachment/12831492/LENS-1308.03.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/983/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544876#comment-15544876 ] Hudson commented on LENS-1340: -- UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #269 (See [https://builds.apache.org/job/Lens-Commit-Java8/269/]) Revert "LENS-1340 : Add DataCompletenessChecker" (amareshwari: rev 1a57cdd82f6d89f37673bfced9fc1a2fb0c65f07) * (delete) lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1340: -- Status: In Progress (was: Patch Available) > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544867#comment-15544867 ] Hudson commented on LENS-1340: -- SUCCESS: Integrated in Jenkins build Lens-Commit #1352 (See [https://builds.apache.org/job/Lens-Commit/1352/]) Revert "LENS-1340 : Add DataCompletenessChecker" (amareshwari: rev 1a57cdd82f6d89f37673bfced9fc1a2fb0c65f07) * (delete) lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1271) Regression tests for Saved Query and Scheduler feature
[ https://issues.apache.org/jira/browse/LENS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544866#comment-15544866 ] Hudson commented on LENS-1271: -- SUCCESS: Integrated in Jenkins build Lens-Commit #1352 (See [https://builds.apache.org/job/Lens-Commit/1352/]) LENS-1271 : Regression tests for Saved Query and Scheduler feature (archanah: rev 5a18cce85185c554193620c63523c0811e097707) * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java * (edit) pom.xml * (add) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SavedQueryResourceHelper.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/testHelper/BaseTestClass.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITPriorityTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java * (edit) lens-regression/pom.xml * (edit) lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java * (add) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ScheduleResourceHelper.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/util/Util.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java * (delete) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java * (add) lens-regression/src/test/java/org/apache/lens/regression/client/ITScheduleQueryTests.java * (add) lens-regression/src/test/java/org/apache/lens/regression/client/ITSavedQueryTests.java > Regression tests for Saved Query and Scheduler feature > -- > > Key: LENS-1271 > URL: https://issues.apache.org/jira/browse/LENS-1271 > Project: Apache Lens > Issue Type: Test > Components: regression >Reporter: Archana H >Assignee: Archana H > Fix For: 2.7 > > Attachments: LENS-1271_5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1326) session/sessions API returning no data on GUI/API though there are active sessions
[ https://issues.apache.org/jira/browse/LENS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544868#comment-15544868 ] Hudson commented on LENS-1326: -- SUCCESS: Integrated in Jenkins build Lens-Commit #1352 (See [https://builds.apache.org/job/Lens-Commit/1352/]) LENS-1326 : Disable hive session and operation timeouts (amareshwari: rev bf25ac578d0643e664daafb2d19f95dda158ea18) * (edit) src/site/apt/admin/config.apt * (edit) lens-server/src/main/resources/lensserver-default.xml > session/sessions API returning no data on GUI/API though there are active > sessions > -- > > Key: LENS-1326 > URL: https://issues.apache.org/jira/browse/LENS-1326 > Project: Apache Lens > Issue Type: Bug >Reporter: Puneet Gupta >Assignee: Lavkesh Lahngir > Fix For: 2.7 > > Attachments: getsession-error.patch, getsession-error.patch, > session-default-value.patch, session-default-value.patch > > > The lens GUI and API is showing no sessions via sessions REST end point. > Server metrics are showing active sessions though. > {noformat} > "org.apache.lens.server.api.session.SessionService.active-sessions" : { > "value" : 5324 >}, > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544865#comment-15544865 ] Narayan Periwal commented on LENS-1340: --- [~amareshwari], resolved the checkstyle issues and submitted the new patch. > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1340: -- Attachment: LENS-1340-v2.patch > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1340: -- Status: Patch Available (was: Reopened) > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1271) Regression tests for Saved Query and Scheduler feature
[ https://issues.apache.org/jira/browse/LENS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544719#comment-15544719 ] Hudson commented on LENS-1271: -- FAILURE: Integrated in Jenkins build Lens-Commit-Java8 #268 (See [https://builds.apache.org/job/Lens-Commit-Java8/268/]) LENS-1271 : Regression tests for Saved Query and Scheduler feature (archanah: rev 5a18cce85185c554193620c63523c0811e097707) * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/testHelper/BaseTestClass.java * (add) lens-regression/src/test/java/org/apache/lens/regression/client/ITSavedQueryTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/util/Util.java * (delete) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java * (edit) lens-regression/pom.xml * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITPriorityTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java * (edit) pom.xml * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java * (add) lens-regression/src/test/java/org/apache/lens/regression/client/ITScheduleQueryTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java * (add) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SavedQueryResourceHelper.java * (add) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ScheduleResourceHelper.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java * (edit) lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java * (edit) lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java > Regression tests for Saved Query and Scheduler feature > -- > > Key: LENS-1271 > URL: https://issues.apache.org/jira/browse/LENS-1271 > Project: Apache Lens > Issue Type: Test > Components: regression >Reporter: Archana H >Assignee: Archana H > Fix For: 2.7 > > Attachments: LENS-1271_5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1308: --- Attachment: LENS-1308.03.patch > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/ --- (Updated Oct. 4, 2016, 1:55 p.m.) Review request for lens. Bugs: LENS-1308 https://issues.apache.org/jira/browse/LENS-1308 Repository: lens Description --- Diffs (updated) - lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 0aada406963f7b421e8b9726a72abcd85c63ddd4 lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 90226d121b5a1ca50e3fcb786437a9198d97a692 Diff: https://reviews.apache.org/r/52028/diff/ Testing --- Thanks, Rajat Khandelwal
Re: Review Request 52088: LENS-743: Query failure retries for transient errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 4, 2016, 1:51 p.m.) Review request for lens. Bugs: LENS-743 https://issues.apache.org/jira/browse/LENS-743 Repository: lens Description --- There have to be retries for query failures for transient errors like network errors (Hive server not reachable/ Metastore not reachable/ DB not reachable). Retries should be available for each phase - submission, execution, updating status, fetching results and formatting. Right now, any such failure results in marking query as failed. Diffs (updated) - checkstyle/src/main/resources/checkstyle.xml 17e55ea1071c06c73e8bf387cd69acca83bc lens-api/src/main/java/org/apache/lens/api/query/FailedAttempt.java PRE-CREATION lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 7d079a9ed99e3d4940d5f26370547683a6bba465 lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java daedbf9ea387cbde3ef39363c2beef3f96725223 lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 04d9ad6dee942c705b0cdf071f49f1305696da65 lens-api/src/test/resources/toString/org.apache.lens.api.query.LensQuery.xml a681bca7fd6e46fe992901e04e025a8a3106 lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryStatus.xml 70f9c932efc090095273566eaa52d380a2f23842 lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java fceabeae9217676774a6978212cbc9ee9ca120f7 lens-driver-es/src/test/resources/hive-site.xml e49c876289d5352203d2523ddb9134d745c197e5 lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0d8810f6b7dfd9fb0173a4be6966f1a561107066 lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java daf01ac64616da72ee55c00f71c2c0aa33651ee4 lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 1acbb13c3a24c0e7b41d799db0d307c5acfa8c6b lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 3c34eb191966dff3ac3032eb79282336b5c6789b lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java 82b56470e2de09f7c41d1226ea59cffdd8d26a26 lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 6e9086f9e8dc302ad2171d7f5636a24cb79dcb50 lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java d80fba9aee91130b69a2a511d7f157c01a261ac4 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8cf617b7181b9a305ea2c68f68c610f823ee75d7 lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java 17bfba02244bca7141268ed12e4a41400e2bec82 lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java 70a34b0c0517ed3b7af46120906fb77ae57870ac lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c lens-server-api/src/main/java/org/apache/lens/server/api/common/OperationRetryHandlerFactory.java 88fbe43318315394873cabb9f5dd39f09f6c47f4 lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java e4984798751d012f0a9d01980df833c206155546 lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 033f6777b4be7a1b6d6cdc350e42a94ade1acbca lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java e472de0a452ffbbcb217503c260aa26fe7f6ed99 lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 5ff59bd0da713651a7cc5261dbd18cd88e91fc76 lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java b58fcf964cedb8dc302099ae9c806b06acafa2d3 lens-server-api/src/main/java/org/apache/lens/server/api/query/PriorityChange.java eaf3fee953e1efbcf151fc844a9441b74b84cc3e lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryAccepted.java 8980b619c9feb86be326bf799fecc35c1579c763 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java a473a47606df84e2b5b204478ad63e63e69b0c23 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java 3837087db6e51c1606573511bfc02b6108d1ef3d lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java b584c6a6d414a6f0dac509e67c8944dbd2373325 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java e80da6d2a417e1274fb186153ec01615c2da565b
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544680#comment-15544680 ] Hudson commented on LENS-1340: -- FAILURE: Integrated in Jenkins build Lens-Commit #1351 (See [https://builds.apache.org/job/Lens-Commit/1351/]) LENS-1340 : Add DataCompletenessChecker (amareshwari: rev 47a3012edc9604e94795d1453a77ac4ee2b1b936) * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu reopened LENS-1340: --- Realized there are checkstyle issues with patch. Reverted the changes. Please fix checkstyle issues. > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1271) Regression tests for Saved Query and Scheduler feature
[ https://issues.apache.org/jira/browse/LENS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544667#comment-15544667 ] Archana H commented on LENS-1271: - committed myself > Regression tests for Saved Query and Scheduler feature > -- > > Key: LENS-1271 > URL: https://issues.apache.org/jira/browse/LENS-1271 > Project: Apache Lens > Issue Type: Test > Components: regression >Reporter: Archana H >Assignee: Archana H > Fix For: 2.7 > > Attachments: LENS-1271_5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1271) Regression tests for Saved Query and Scheduler feature
[ https://issues.apache.org/jira/browse/LENS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana H updated LENS-1271: Fix Version/s: 2.7 > Regression tests for Saved Query and Scheduler feature > -- > > Key: LENS-1271 > URL: https://issues.apache.org/jira/browse/LENS-1271 > Project: Apache Lens > Issue Type: Test > Components: regression >Reporter: Archana H >Assignee: Archana H > Fix For: 2.7 > > Attachments: LENS-1271_5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1271) Regression tests for Saved Query and Scheduler feature
[ https://issues.apache.org/jira/browse/LENS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana H updated LENS-1271: Resolution: Fixed Status: Resolved (was: Patch Available) > Regression tests for Saved Query and Scheduler feature > -- > > Key: LENS-1271 > URL: https://issues.apache.org/jira/browse/LENS-1271 > Project: Apache Lens > Issue Type: Test > Components: regression >Reporter: Archana H >Assignee: Archana H > Fix For: 2.7 > > Attachments: LENS-1271_5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544650#comment-15544650 ] Hudson commented on LENS-1340: -- FAILURE: Integrated in Jenkins build Lens-Commit-Java8 #267 (See [https://builds.apache.org/job/Lens-Commit-Java8/267/]) LENS-1340 : Add DataCompletenessChecker (amareshwari: rev 47a3012edc9604e94795d1453a77ac4ee2b1b936) * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1326) session/sessions API returning no data on GUI/API though there are active sessions
[ https://issues.apache.org/jira/browse/LENS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544651#comment-15544651 ] Hudson commented on LENS-1326: -- FAILURE: Integrated in Jenkins build Lens-Commit-Java8 #267 (See [https://builds.apache.org/job/Lens-Commit-Java8/267/]) LENS-1326 : Disable hive session and operation timeouts (amareshwari: rev bf25ac578d0643e664daafb2d19f95dda158ea18) * (edit) src/site/apt/admin/config.apt * (edit) lens-server/src/main/resources/lensserver-default.xml > session/sessions API returning no data on GUI/API though there are active > sessions > -- > > Key: LENS-1326 > URL: https://issues.apache.org/jira/browse/LENS-1326 > Project: Apache Lens > Issue Type: Bug >Reporter: Puneet Gupta >Assignee: Lavkesh Lahngir > Fix For: 2.7 > > Attachments: getsession-error.patch, getsession-error.patch, > session-default-value.patch, session-default-value.patch > > > The lens GUI and API is showing no sessions via sessions REST end point. > Server metrics are showing active sessions though. > {noformat} > "org.apache.lens.server.api.session.SessionService.active-sessions" : { > "value" : 5324 >}, > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1326) session/sessions API returning no data on GUI/API though there are active sessions
[ https://issues.apache.org/jira/browse/LENS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1326: -- Resolution: Fixed Fix Version/s: 2.7 Status: Resolved (was: Patch Available) > session/sessions API returning no data on GUI/API though there are active > sessions > -- > > Key: LENS-1326 > URL: https://issues.apache.org/jira/browse/LENS-1326 > Project: Apache Lens > Issue Type: Bug >Reporter: Puneet Gupta >Assignee: Lavkesh Lahngir > Fix For: 2.7 > > Attachments: getsession-error.patch, getsession-error.patch, > session-default-value.patch, session-default-value.patch > > > The lens GUI and API is showing no sessions via sessions REST end point. > Server metrics are showing active sessions though. > {noformat} > "org.apache.lens.server.api.session.SessionService.active-sessions" : { > "value" : 5324 >}, > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1326) session/sessions API returning no data on GUI/API though there are active sessions
[ https://issues.apache.org/jira/browse/LENS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544595#comment-15544595 ] Amareshwari Sriramadasu commented on LENS-1326: --- +1 > session/sessions API returning no data on GUI/API though there are active > sessions > -- > > Key: LENS-1326 > URL: https://issues.apache.org/jira/browse/LENS-1326 > Project: Apache Lens > Issue Type: Bug >Reporter: Puneet Gupta >Assignee: Lavkesh Lahngir > Attachments: getsession-error.patch, getsession-error.patch, > session-default-value.patch, session-default-value.patch > > > The lens GUI and API is showing no sessions via sessions REST end point. > Server metrics are showing active sessions though. > {noformat} > "org.apache.lens.server.api.session.SessionService.active-sessions" : { > "value" : 5324 >}, > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-1340: -- Resolution: Fixed Fix Version/s: 2.7 Status: Resolved (was: Patch Available) Committed. Thanks [~nperiwal] > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52484: LENS-1343: expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52484/#review151308 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 3, 2016, 2:14 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52484/ > --- > > (Updated Oct. 3, 2016, 2:14 p.m.) > > > Review request for lens. > > > Bugs: LENS-1343 > https://issues.apache.org/jira/browse/LENS-1343 > > > Repository: lens > > > Description > --- > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 6e52d32f5b4e2e4a0579e9d9b010f361e8aad24d > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 861d4f7b5544d28e09af398c50223d04b13ac191 > lens-cube/src/test/resources/hive-site.xml > d21e61c2bcd68adbd579b8bf6dffbeec9fa24fd7 > > Diff: https://reviews.apache.org/r/52484/diff/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >